Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - fix(category_theory/concrete): access the carrier type by the coercion#2473

Closed
kim-em wants to merge 1 commit into
masterfrom
bundled_use_coercion
Closed

[Merged by Bors] - fix(category_theory/concrete): access the carrier type by the coercion#2473
kim-em wants to merge 1 commit into
masterfrom
bundled_use_coercion

Conversation

@kim-em

@kim-em kim-em commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator

This should marginally reduce the pain of using concrete categories, as the underlying types of a bundled object should more uniformly described via a coercion, rather than the projection.

(There's still some separate pain involving bundled.map, but it has an orthogonal fix which I'm working on in another branch.)

@kim-em kim-em added the awaiting-review The author would like community review of the PR label Apr 21, 2020

@jcommelin jcommelin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors merge

@github-actions github-actions Bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 21, 2020
bors Bot pushed a commit that referenced this pull request Apr 21, 2020
#2473)

This should marginally reduce the pain of using concrete categories, as the underlying types of a bundled object should more uniformly described via a coercion, rather than the `.α` projection.

(There's still some separate pain involving `bundled.map`, but it has an orthogonal fix which I'm working on in another branch.)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors

bors Bot commented Apr 21, 2020

Copy link
Copy Markdown

Pull request successfully merged into master.

Build succeeded:

@bors bors Bot changed the title fix(category_theory/concrete): access the carrier type by the coercion [Merged by Bors] - fix(category_theory/concrete): access the carrier type by the coercion Apr 21, 2020
@bors bors Bot closed this Apr 21, 2020
@bors bors Bot deleted the bundled_use_coercion branch April 21, 2020 06:27
butterthebuddha pushed a commit to butterthebuddha/mathlib that referenced this pull request May 15, 2020
leanprover-community#2473)

This should marginally reduce the pain of using concrete categories, as the underlying types of a bundled object should more uniformly described via a coercion, rather than the `.α` projection.

(There's still some separate pain involving `bundled.map`, but it has an orthogonal fix which I'm working on in another branch.)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
butterthebuddha pushed a commit to butterthebuddha/mathlib that referenced this pull request May 16, 2020
leanprover-community#2473)

This should marginally reduce the pain of using concrete categories, as the underlying types of a bundled object should more uniformly described via a coercion, rather than the `.α` projection.

(There's still some separate pain involving `bundled.map`, but it has an orthogonal fix which I'm working on in another branch.)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
leanprover-community#2473)

This should marginally reduce the pain of using concrete categories, as the underlying types of a bundled object should more uniformly described via a coercion, rather than the `.α` projection.

(There's still some separate pain involving `bundled.map`, but it has an orthogonal fix which I'm working on in another branch.)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants