This repository was archived by the owner on Jul 24, 2024. It is now read-only.
feat(data/quot): quotient.ind'#691
Merged
Merged
Conversation
cipher1024
pushed a commit
that referenced
this pull request
Feb 8, 2019
* feat(data/quot): quotient.ind' * correct elaborator tag; theorems not definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list
Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/quotient.2Einduction_on.20order.20of.20variables
I don't know about the elaborator tags for these quotient.blah functions. Some are tagged reducible and others aren't; many are tagged
elab_as_eliminator. Many are marked protected. I understand what protected means so I went with it; I do not really understand the practicalities of the elaborator tags so I left them, in order not to give the impression that I know what I'm doing there.