Skip to content

Conversation

@anishmanandhar
Copy link
Collaborator

Screen Shot 2020-06-22 at 12 21 00 PM

@anishmanandhar anishmanandhar added the documentation Improvements or additions to documentation label Jun 22, 2020

#### The following convention should be followed for REST API Headers

* Headers names should be **noun** and should be **Captialised-Case** separated by **(-)**. e.g **Token-Key**, **Account-ID**, **Tenant-ID** etc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Headers names should be **noun** and should be **Captialised-Case** separated by **(-)**. e.g **Token-Key**, **Account-ID**, **Tenant-ID** etc
* Headers names should be **noun** and should be **Capitalised-Case** separated by **(-)**. e.g **Token-Key**, **Account-ID**, **Tenant-ID** etc


* Never expose information on URLs. <https://api.app.com/users/{id}/fetch?apiKey=abcd123456789> //Bad practice

* Conside using token based authentication like OAUTH2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Conside using token based authentication like OAUTH2
* Consider using token based authentication like OAUTH2

@anishmanandhar anishmanandhar merged commit 0564f2f into develop Jun 26, 2020
@mesaugat mesaugat deleted the rest-api branch June 26, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants