[CI] Fix nolint-check that are reporting always OK #678
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export CHANGED_FILES="$(git diff --name-only origin/$BASE_REF HEAD | grep '^tasks/')" | ||
| set -euo pipefail | ||
| CHANGED_FILES="$(git diff --name-only "$BASE_SHA"..."$HEAD_SHA" -- 'tasks/')" |
There was a problem hiding this comment.
The new CHANGED_FILES assignment escapes the quotes around HEAD_SHA (git diff --name-only "$BASE_SHA"...\"$HEAD_SHA\" -- 'tasks/'), which produces the literal range BASE..."<sha>". git diff treats that as an invalid revision and exits with fatal: bad revision, and with set -euo pipefail the nolint-check step will now fail before scanning files on every PR. The range should not include escaped quotes around HEAD_SHA.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 15 15
Lines 486 486
Branches 181 181
=======================================
Hits 457 457
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
No description provided.