Bug - delete posts / Markposts

[Varanity]

Markposts
In the case of one of our users, it happened that a topic displayed all the time that there was a new message, even though there was no new message there. Unfortunately, this display does not go away. I have tested this, but could not reproduce the bug.

Furthermore, the “Mark all posts in this forum as read” button / dustbin does not work for us. If you click on it, you are redirected to an empty page. The notifications remain. The notifications only disappear when you actually click on the topic.
An example of the link to which you are redirected (empty page): xyz.domain.ending/mod/moodleoverflow/markposts.php?m=12&d=5

Delete post
If a user tries to delete their comment, but it contains other comments, the error message below will appear.

Coding error detected, it must be fixed by a programmer: Url parameters can not have numeric keys!

Weitere Informationen über diesen Fehler
Debug info:
Error code: codingerror
Stack trace:

line 191 of /lib/classes/url.php: core\exception\coding_exception thrown
line 171 of /lib/classes/url.php: call to core\url->params()
line 457 of /mod/moodleoverflow/post.php: call to core\url->__construct()

[TamaroWalter]

Hi @Varanity,

thank you for your detailed issue description, i will check this and try to fix it.

[TamaroWalter]

HI @Varanity,

I found the problems you mentioned although I could not reproduce the exact error message ( I found no error message that matches yours, but deleting posts with replies does indeed throw an exception that can not be exited).
The problem about the topic that is always displayed I couldn't reproduce either. Is there a possibility of sending me a screenshot?

The dust bin problem is solved and the problem with deleting posts with replies too. More Information about the solution and the bug are in the linked pull request.

There's going to be a new moodleoverflow release soon. Feel free to update the plugin then :).
Kind regards

[Varanity]

Hello @TamaroWalter ,

I'm glad to hear that. Thank you very much! :)
I wrote to the user who reported the problem, but unfortunately I didn't get a reply. So I think it was a one-off problem. If it happens again, I will let you know

Best wishes