Pr bugfix man and auto trigger #269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
Please describe the purpose of this PR in a few sentences.
So far: You can combine a manual trigger with an automatic trigger but the automatic trigger is silently ignored when running the workflow. Only the manual trigger is executed.
The pull request determines the course set of the automatic trigger (or triggers) and applies the manual trigger only to this course subset.
Why is this change or addition necessary?
It enables restricting a manual trigger to a course category by simply combining it with the category trigger.
Of course the manual trigger can also be combined with other automatic triggers.
What is the expected behavior after the change?
When combining a manual trigger with an automatic trigger, the automatic trigger shall no longer be ignored.
📋 Checklist
Please confirm the following (check all that apply):
phpunitand/orbehattests that cover my changes or additions.var_dump()orvar_exportor any other debugging statements (or commented out code) thatshould not appear on the productive branch.
db/upgrade.phpandupdated the
version.php..minfiles with thegrunt amdcommand.version.phpand theCHANGES.md.I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
changes in the plugins UI.
🔍 Related Issues
🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)
Any other relevant information.
Behat test scenario is added.
Only and combination is code. OR combination can be replaced by multiple workflows and is less interesting.