Skip to content

Conversation

@KBorm
Copy link
Contributor

@KBorm KBorm commented Nov 18, 2025

Note: Please fill out all relevant sections and remove irrelevant ones.

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

Please describe the purpose of this PR in a few sentences.

  • What feature or bug does it address?
    So far: You can combine a manual trigger with an automatic trigger but the automatic trigger is silently ignored when running the workflow. Only the manual trigger is executed.

The pull request determines the course set of the automatic trigger (or triggers) and applies the manual trigger only to this course subset.

  • Why is this change or addition necessary?
    It enables restricting a manual trigger to a course category by simply combining it with the category trigger.
    Of course the manual trigger can also be combined with other automatic triggers.

  • What is the expected behavior after the change?
    When combining a manual trigger with an automatic trigger, the automatic trigger shall no longer be ignored.


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

  • Related to #

🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Any other relevant information.

Behat test scenario is added.
Only and combination is code. OR combination can be replaced by multiple workflows and is less interesting.


@bluetom bluetom self-assigned this Nov 18, 2025
@bluetom bluetom merged commit e33088d into learnweb:main Nov 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants