snapshots: fix filesByRange (#9472)#9488
Merged
battlmonstr merged 1 commit intodevelfrom Feb 22, 2024
Merged
Conversation
AskAlexSharov
approved these changes
Feb 22, 2024
The method was iterating over snapshots.segments.Min().segments, but passing the index to view.Segments(). This might lead to a crash, because those 2 collections are different, and the indexes might not match. view.Segments() only contains the snapshot files that are fully downloaded and indexed. The code is changed to only use the view files (as it was before).
battlmonstr
force-pushed
the
pr/snapshots_merge_fix
branch
from
a668aa0 to
8a1ca21
Compare
Contributor
Author
|
release patch: #9489 |
yperbasis
pushed a commit
that referenced
this pull request
Feb 22, 2024
The method was iterating over snapshots.segments.Min().segments, but passing the index to view.Segments(). This might lead to a crash, because those 2 collections are different, and the indexes might not match. view.Segments() only contains the snapshot files that are fully downloaded and indexed. The code is changed to only use the view files (as it was before).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method was iterating over snapshots.segments.Min().segments, but passing the index to view.Segments().
This might lead to a crash, because those 2 collections are different, and the indexes might not match.
view.Segments() only contains the snapshot files that are fully downloaded and indexed.
The code is changed to only use the view files (as it was before).