canny preprocessor fixes #861
Conversation
The sd_image_t struct is passed by value, so the data pointer can't be changed. Instead, just overwrite the image data area.
Tested from 64x64 to 2048x2048. Fixes leejet#253 Fixes leejet#642
wbruna
force-pushed
the
fix_canny_preprocessing
branch
from
7b8adc1 to
0986a21
Compare
|
It looks like this just increases the size of |
|
The struct is also received by value, so freeing the data buffer leaves behind an invalid pointer; so I'm reusing the existing buffer instead.. |
|
So it’s just to avoid reallocating memory, and it won’t affect the result? |
It's more like 'avoid changing the data pointer', since we can't alter its value for the code layers above (it's a C interface). It shouldn't affect the canny processing result in any way: the input image is only used to initialize the tensors, so it's safe to overwrite it at that later point. (of course, on current master, the data pointer ends up pointing to a freed buffer, so the image data could have been changed (corrupted) by the program elsewhere. In that sense, image results could be different.) |
|
I forgot that the parameter is passed by value, so it makes sense. |
|
Thank you for your contribution. |
2 participants
No description provided.