feat: support independent sampler rng #978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ComfyUI, when using samplers that include ancestral sampling steps (such as euler_a), an independent RNG is used to generate noise. Moreover, ComfyUI uses the RNG of the device where the current tensor resides. This means that if ComfyUI is running on CUDA, the initial noise is generated on the CPU, but the noise added during sampling is generated on CUDA. If ComfyUI is running on another device, such as the CPU, the results will be different.
The ComfyUI commit that introduced this issue: comfyanonymous/ComfyUI@916d1e1.
I don’t really understand why ComfyUI is designed this way, as it breaks cross-device consistency and causes different versions of ComfyUI to produce different outputs. However, for users who want to reproduce ComfyUI’s results in sd.cpp, this PR is necessary.
sd.cpp result

comfyui result
