some modifications #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the same changes I made to FastBitSet, with a couple of modifications specific to this library:
I eliminated the
countproperty from the prototypeTypedFastBitSetobject. since it appears to be unnecessary.this.words.lengthseems to be fine. Am I missing something?I noticed the
hammingWeight4()fromFastBitSet, which is not used internally, so I tried it out for thesize()method and it works great. On my laptop the cardinality test typically runs ~30ms faster.npm complained of a vulnerability and suggested
npm audit fix, which I did and it updated a dependency, which is reflected inpackage.jsonandpackage-lock.json.After making my initial changes I discovered I was working with an older version of
TypedFastBitSetthat I forked several months ago, so I merged the updates and fixed a few conflicts.