Update main.js #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to ensure that Houses are loaded and displayed before Characters
A few corrections with english expressions and typos.
JaimeSalas
reviewed
Mar 21, 2018
01 Non blocking/README.md
Outdated
|
|
||
| * But if just one thing per time it's executed, how is this possible? | ||
| * Inside Chrome developer tools, on the network tab, we can notice that the requests are being sent concurrently. | ||
|
|
There was a problem hiding this comment.
typo!
somehow... that's not what I have in my code wich is :
-
But if just one thing at a time is executed, how is this possible?
-
Inside Chrome developer tools, on the network tab, we can notice that the requests are being sent concurrently.
JaimeSalas
reviewed
Mar 21, 2018
|
|
||
| ## In this demo we are going to study the non blocking nature of JavaScript | ||
|
|
||
| * Just one thing can happen per time in JavaScript. But the required time to get data loaded is really short. Is not just to have a really good network capabilities, there is another reason. |
JaimeSalas
reviewed
Mar 21, 2018
01 Non blocking/src/js/main.js
Outdated
| service.getCharactersByName(characterInput.value, charactersRequestConfig); | ||
| service.getHousesByName(houseInput.value, housesRequestConfig); | ||
| setTimeout(() => { | ||
| console.log('2'); |
There was a problem hiding this comment.
No setTimeout solution, it's not a good approach.
Changes made to use callbacks: + Changed solution to fit callback implementation + Added new function getCharacters + Remake and rename for handleHousesRequestSuccess (there was a typo in handleHousesRequestSuccess function)
updated
|
updated files due to comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to ensure that Houses are loaded and displayed before Characters