Cannot read property 'state' of undefined at onSave in 07 Form

[qkreltms]

Error happens when Button from "../../common/components/form"; clicked.
It is because onSave doesn't bound on the constructor in MemberPageContainer class.

Original code

react-typescript-samples/07 Form/src/components/member/pageContainer.tsx

Lines 17 to 28 in 8d0550b

	constructor(props: Props) {
	super(props);
	this.state = {
	member: {
	id: -1,
	login: '',
	avatar_url: '',
	}
	};
	this.onFieldValueChange = this.onFieldValueChange.bind(this);

  constructor(props: any) {
      super(props)

      this.state = {
        member: {
          id: -1,
          login: "",
          avatar_url: ""
        }
      };

      this.onFieldValueChange = this.onFieldValueChange.bind(this);
      //You should include this
      this.onSave = this.onSave.bind(this);
  }

[brauliodiez]

Hi thanks for opening the issue, just reviewing seems to working fine, the thing is instead of using bind.this I use fat arrow approach to keep the _this_context.

  private onSave = () => {
    memberAPI.saveMember(this.state.member)
      .then(() => {
        toastr.success('Member saved.');
        this.props.history.goBack();
      });
  }

That works fine on Typescript classes, the reason why there is a mix of bind.this and fat arrow is just versioning, I think it would be a good idea to move everything to fat arrow, if you want to take this issue you are more than welcome.

About data not being saved is because is not really saving (member reads from github api).

If you can provide further information or you want to get involved enhancing the samples that would be of great help, thanks.