Skip to content

Conversation

@dcaswel
Copy link

@dcaswel dcaswel commented Mar 2, 2017

This request contains implementations of the Refund, Void, and Capture requests. I also added testing for those requests as well as an integration test class for testing the functionality while it is actually interacting with Beanstream.

Derek Caswell added 3 commits March 1, 2017 17:29
…for them. Still need to finish creating the tests.
…apture functionality and created tests for it as well.
…correct type code that beanstream uses. This commit also has an integration test class added for testing actual transactions with beanstream.
@dcaswel
Copy link
Author

dcaswel commented Mar 2, 2017

@aperdomo The output from travis-ci is a little vague. Could you shine some light on why the checks are failing for this PR? Thanks!

@dcaswel
Copy link
Author

dcaswel commented Mar 7, 2017

So...I must have been blind when I looked at the output from the CI before. I guess I was just looking at the red text at the bottom. :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 93.156% when pulling 5ade4ce on CaswellWC:master into 71526db on lemonstand:master.

2 similar comments
@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage increased (+0.4%) to 93.156% when pulling 5ade4ce on CaswellWC:master into 71526db on lemonstand:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 93.156% when pulling 5ade4ce on CaswellWC:master into 71526db on lemonstand:master.

Copy link
Contributor

@aperdomo aperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaswellWC

Sorry for the delay on this - PR looks good.

@aperdomo aperdomo merged commit 2716e50 into lemonstand:master Mar 7, 2017
@dcaswel
Copy link
Author

dcaswel commented Mar 7, 2017

@aperdomo
No problem. If you feel comfortable doing so, I would appreciate it if this could get put into a new release as well. Thanks!

@aperdomo aperdomo mentioned this pull request Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants