Add metadata and inspect debug info #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdonovick
reviewed
Aug 22, 2019
cdonovick
approved these changes
Aug 22, 2019
Collaborator
cdonovick
left a comment
cdonovick
left a comment
There was a problem hiding this comment.
Modulo type annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to pass a metadata dictionary between passes. The initial entries are
source_filenameandsource_lineswhich are populated byinspect.getsourcefile(fn)andinspect.getsourcelines(fn)when the flags are set forbegin_rewrite. This debug information is used by magma to generate error messages (the important part of getsourcelines is that it provides the starting line number and the actual source lines which could be different compared to simply unparsing the AST (e.g. if there are linebreaks in the user code not represented in the AST).