Fix inline blacklist logic for recursive case #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before if we had a module such as:
We would get
Notice the (i1 - i2) is inlined into the slice node, which is invalid.
The reason was the blacklisting logic was not recursively checking
identifiers. That is, when we encounter a slice, we let a an
identifier be inlined for another identifier into the contents of the
slice. However, this is problematic when the identifier being inlined
will in turn be replaced by something which may not be valid (e.g. an
expression). So, we improve the blacklisting logic to recursively check
inlined identifiers until we encounter an invalid driver of inlining.
At this point, we blacklist the current identifier so that it will not
be eventually inlined into the slice/index node.
So, for the above example we now get