Enforce the PSR-12 order of use statements #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSR-12 states that the order should be: classes, functions, constants
Contributor
Author
|
Should this be released as a new major version, since this is backward incompatible with the previous order (classes, constants, functions)? Or are we fine with fixing this in the existing codebases? |
VSlokker
approved these changes
May 16, 2018
Contributor
VSlokker
left a comment
VSlokker
left a comment
There was a problem hiding this comment.
I'm fine with fixing it.
ctoffanin
approved these changes
May 16, 2018
Contributor
Author
|
Undo when slevomat/coding-standard#346 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSR-12 states that the order should be: classes, functions, constants. PhpStorm (as of version 2018.1) also uses this order when you reformat your code, so it is annoying when our coding standard enforces something different.