-
Notifications
You must be signed in to change notification settings - Fork 3
fix: remove title field from generate-spec prompt #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove redundant title field from the generate-spec prompt frontmatter as the name field is sufficient for identification. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughRemoved propagation and storage of a Changes
Sequence Diagram(s)sequenceDiagram
participant Loader as load_markdown_prompt
participant FM as FrontMatter (file)
participant Prompt as MarkdownPrompt
rect rgba(200,230,201,0.6)
Note over Loader,FM: Old flow (before changes)
Loader->>FM: read frontmatter (title, description, allowed-tools, ...)
Loader->>Prompt: construct MarkdownPrompt(title, description, meta...)
end
rect rgba(187,222,251,0.6)
Note over Loader,FM: New flow (after changes)
Loader->>FM: read frontmatter (description, meta.allowed-tools, ...)
Loader->>Prompt: construct MarkdownPrompt(description, meta..., *no title*)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
@iaminawe need to remove the titles from the other prompts, too. And probably the prompt metadata parsing logic. |
Remove the title field from all prompt frontmatter files and the MarkdownPrompt parser to fix Claude Code slash command parsing issues. The title field with spaces was causing slash commands to break at the first space character. Changes: - Remove title field from MarkdownPrompt dataclass - Remove title handling in decorator_kwargs() method - Remove title extraction in load_markdown_prompt() - Remove title field from all three prompt files - Add quotes to description fields for consistency - Fix indentation in manage-tasks.md meta section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update test fixtures to remove the title field from prompt frontmatter, matching the changes made to the actual prompt files and parser. Also fix indentation for allowed-tools in manage-tasks test fixture. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the redundant title field from prompt frontmatter configurations across the codebase. The name field already provides sufficient identification for prompts, making title unnecessary. The change also standardizes description values to use quoted strings in the YAML frontmatter.
- Removed the
titlefield from theMarkdownPromptdataclass and related processing logic - Updated all prompt files to remove the
titlefield and quote description values - Updated test fixtures to match the new frontmatter structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mcp_server/prompt_utils.py | Removed title field from MarkdownPrompt class and its processing in load_markdown_prompt function |
| prompts/generate-spec.md | Removed title field and quoted the description value |
| prompts/generate-task-list-from-spec.md | Removed title field and quoted the description value |
| prompts/manage-tasks.md | Removed title field and quoted the description value |
| tests/conftest.py | Updated test fixtures to remove title field from all prompt configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
titlefield from the generate-spec prompt frontmatterDetails
The
titlefield in the prompt frontmatter is redundant as thenamefield already provides sufficient identification. This change simplifies the prompt configuration by removing the unnecessary field.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit