Deprecate NumericVector::type() that returns a writable reference #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user should not be allowed to change the ParallelType of a NumericVector on the fly. Ideally, this flag should be set prior to the vector being initialized, and then not changed. If we do need to support changing it, it would be better to have a dedicated NumericVector::set_type() API that does this, but we would still need to restrict when such an API would be allowed to be called.
The new arg defaults to AUTOMATIC, so the behavior should be exactly the same as it was previously, although now we have the chance to set a custom ParallelType via the NumericVector::build() API.
Making this a generic setter opens up the possibility that we will support more complicated/expensive type conversions later. For now, we just throw a libmesh_not_implemented() error when the user requests to change the ParallelType of an already-initialized NumericVector.
|
Job Coverage, step Generate coverage on d13c580 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
roystgnr
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add
NumericVector::set_type(t)that allows the user to change theNumericVectorParallelTypein some situations. I'm going to attach a--disable-deprecatedbuild to this PR to see whether there is any downstream code that is currently using the API. I only located two instances of it (in the same function) within libmesh itself.