Make sure dof index containers sized even when not active on block #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make sure that we properly size dof index containers to be inclusive of variables that are not defined on the current subdomain ID. So for a given element we can index into the container at that variable number and then obviously the associated vector of indices will be of zero length since there are no dof indices
|
Job Coverage, step Generate coverage on 2905cb5 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
roystgnr
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure that we properly size dof index containers to be inclusive of variables that are not defined on the current subdomain ID. So for a given element we can index into the container at that variable number and then obviously the associated vector of indices will be of zero length since there are no dof indices
Refs @GiudGiud's investigation on idaholab/moose#30357