Skip to content

Refactor universal messages into new variant namespace. #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Refactor universal messages into new variant namespace. #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ src_libbitcoin_network_la_SOURCES = \
src/log/capture.cpp \
src/log/logger.cpp \
src/log/reporter.cpp \
src/messages/http/body.cpp \
src/messages/http/fields.cpp \
src/messages/http/head.cpp \
src/messages/http/enums/mime_type.cpp \
src/messages/http/enums/target.cpp \
src/messages/json/body.cpp \
Expand Down Expand Up @@ -100,6 +100,8 @@ src_libbitcoin_network_la_SOURCES = \
src/messages/peer/version.cpp \
src/messages/peer/version_acknowledge.cpp \
src/messages/peer/witness_tx_id_relay.cpp \
src/messages/variant/body.cpp \
src/messages/variant/head.cpp \
src/net/acceptor.cpp \
src/net/broadcaster.cpp \
src/net/connector.cpp \
Expand Down Expand Up @@ -170,10 +172,9 @@ test_libbitcoin_network_test_SOURCES = \
test/config/utilities.cpp \
test/log/timer.cpp \
test/log/tracker.cpp \
test/messages/http/body_reader.cpp \
test/messages/http/body_writer.cpp \
test/messages/http/fields.cpp \
test/messages/http/method.cpp \
test/messages/http/head_reader.cpp \
test/messages/http/head_writer.cpp \
test/messages/http/enums/magic_numbers.cpp \
test/messages/http/enums/mime_type.cpp \
test/messages/http/enums/target.cpp \
Expand Down Expand Up @@ -224,6 +225,11 @@ test_libbitcoin_network_test_SOURCES = \
test/messages/peer/enums/level.cpp \
test/messages/peer/enums/magic_numbers.cpp \
test/messages/peer/enums/service.cpp \
test/messages/variant/body_reader.cpp \
test/messages/variant/body_writer.cpp \
test/messages/variant/head_reader.cpp \
test/messages/variant/head_writer.cpp \
test/messages/variant/method.cpp \
test/net/acceptor.cpp \
test/net/broadcaster.cpp \
test/net/connector.cpp \
Expand Down Expand Up @@ -347,14 +353,9 @@ include_bitcoin_network_log_HEADERS = \

include_bitcoin_network_messages_httpdir = ${includedir}/bitcoin/network/messages/http
include_bitcoin_network_messages_http_HEADERS = \
include/bitcoin/network/messages/http/body.hpp \
include/bitcoin/network/messages/http/fields.hpp \
include/bitcoin/network/messages/http/head.hpp \
include/bitcoin/network/messages/http/http.hpp \
include/bitcoin/network/messages/http/method.hpp \
include/bitcoin/network/messages/http/request.hpp \
include/bitcoin/network/messages/http/response.hpp \
include/bitcoin/network/messages/http/types.hpp
include/bitcoin/network/messages/http/http.hpp

include_bitcoin_network_messages_http_enumsdir = ${includedir}/bitcoin/network/messages/http/enums
include_bitcoin_network_messages_http_enums_HEADERS = \
Expand Down Expand Up @@ -421,6 +422,15 @@ include_bitcoin_network_messages_peer_enums_HEADERS = \
include/bitcoin/network/messages/peer/enums/magic_numbers.hpp \
include/bitcoin/network/messages/peer/enums/service.hpp

include_bitcoin_network_messages_variantdir = ${includedir}/bitcoin/network/messages/variant
include_bitcoin_network_messages_variant_HEADERS = \
include/bitcoin/network/messages/variant/body.hpp \
include/bitcoin/network/messages/variant/head.hpp \
include/bitcoin/network/messages/variant/method.hpp \
include/bitcoin/network/messages/variant/request.hpp \
include/bitcoin/network/messages/variant/response.hpp \
include/bitcoin/network/messages/variant/variant.hpp

include_bitcoin_network_netdir = ${includedir}/bitcoin/network/net
include_bitcoin_network_net_HEADERS = \
include/bitcoin/network/net/acceptor.hpp \
Expand Down
14 changes: 10 additions & 4 deletions builds/cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ add_library( ${CANONICAL_LIB_NAME}
"../../src/log/capture.cpp"
"../../src/log/logger.cpp"
"../../src/log/reporter.cpp"
"../../src/messages/http/body.cpp"
"../../src/messages/http/fields.cpp"
"../../src/messages/http/head.cpp"
"../../src/messages/http/enums/mime_type.cpp"
"../../src/messages/http/enums/target.cpp"
"../../src/messages/json/body.cpp"
Expand Down Expand Up @@ -282,6 +282,8 @@ add_library( ${CANONICAL_LIB_NAME}
"../../src/messages/peer/version.cpp"
"../../src/messages/peer/version_acknowledge.cpp"
"../../src/messages/peer/witness_tx_id_relay.cpp"
"../../src/messages/variant/body.cpp"
"../../src/messages/variant/head.cpp"
"../../src/net/acceptor.cpp"
"../../src/net/broadcaster.cpp"
"../../src/net/connector.cpp"
Expand Down Expand Up @@ -376,10 +378,9 @@ if (with-tests)
"../../test/config/utilities.cpp"
"../../test/log/timer.cpp"
"../../test/log/tracker.cpp"
"../../test/messages/http/body_reader.cpp"
"../../test/messages/http/body_writer.cpp"
"../../test/messages/http/fields.cpp"
"../../test/messages/http/method.cpp"
"../../test/messages/http/head_reader.cpp"
"../../test/messages/http/head_writer.cpp"
"../../test/messages/http/enums/magic_numbers.cpp"
"../../test/messages/http/enums/mime_type.cpp"
"../../test/messages/http/enums/target.cpp"
Expand Down Expand Up @@ -430,6 +431,11 @@ if (with-tests)
"../../test/messages/peer/enums/level.cpp"
"../../test/messages/peer/enums/magic_numbers.cpp"
"../../test/messages/peer/enums/service.cpp"
"../../test/messages/variant/body_reader.cpp"
"../../test/messages/variant/body_writer.cpp"
"../../test/messages/variant/head_reader.cpp"
"../../test/messages/variant/head_writer.cpp"
"../../test/messages/variant/method.cpp"
"../../test/net/acceptor.cpp"
"../../test/net/broadcaster.cpp"
"../../test/net/connector.cpp"
Expand Down
28 changes: 20 additions & 8 deletions builds/msvc/vs2022/libbitcoin-network-test/libbitcoin-network-test.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,20 +146,17 @@
<ClCompile Include="..\..\..\..\test\log\tracker.cpp" />
<ClCompile Include="..\..\..\..\test\main.cpp" />
<ClCompile Include="..\..\..\..\test\memory.cpp" />
<ClCompile Include="..\..\..\..\test\messages\http\body_reader.cpp">
<ObjectFileName>$(IntDir)test_messages_http_body_reader.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\body_writer.cpp">
<ObjectFileName>$(IntDir)test_messages_http_body_writer.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\enums\magic_numbers.cpp">
<ObjectFileName>$(IntDir)test_messages_http_enums_magic_numbers.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\enums\mime_type.cpp" />
<ClCompile Include="..\..\..\..\test\messages\http\enums\target.cpp" />
<ClCompile Include="..\..\..\..\test\messages\http\fields.cpp" />
<ClCompile Include="..\..\..\..\test\messages\http\method.cpp">
<ObjectFileName>$(IntDir)test_messages_http_method.obj</ObjectFileName>
<ClCompile Include="..\..\..\..\test\messages\http\head_reader.cpp">
<ObjectFileName>$(IntDir)test_messages_http_head_reader.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\head_writer.cpp">
<ObjectFileName>$(IntDir)test_messages_http_head_writer.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\json\body_reader.cpp">
<ObjectFileName>$(IntDir)test_messages_json_body_reader.obj</ObjectFileName>
Expand Down Expand Up @@ -216,6 +213,21 @@
<ClCompile Include="..\..\..\..\test\messages\peer\version.cpp" />
<ClCompile Include="..\..\..\..\test\messages\peer\version_acknowledge.cpp" />
<ClCompile Include="..\..\..\..\test\messages\peer\witness_tx_id_relay.cpp" />
<ClCompile Include="..\..\..\..\test\messages\variant\body_reader.cpp">
<ObjectFileName>$(IntDir)test_messages_variant_body_reader.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\body_writer.cpp">
<ObjectFileName>$(IntDir)test_messages_variant_body_writer.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\head_reader.cpp">
<ObjectFileName>$(IntDir)test_messages_variant_head_reader.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\head_writer.cpp">
<ObjectFileName>$(IntDir)test_messages_variant_head_writer.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\method.cpp">
<ObjectFileName>$(IntDir)test_messages_variant_method.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\test\net.cpp" />
<ClCompile Include="..\..\..\..\test\net\acceptor.cpp" />
<ClCompile Include="..\..\..\..\test\net\broadcaster.cpp" />
Expand Down
33 changes: 24 additions & 9 deletions builds/msvc/vs2022/libbitcoin-network-test/libbitcoin-network-test.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000B}</UniqueIdentifier>
</Filter>
<Filter Include="src\messages\http\enums">
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000E}</UniqueIdentifier>
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000F}</UniqueIdentifier>
</Filter>
<Filter Include="src\messages\json">
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000C}</UniqueIdentifier>
Expand All @@ -41,7 +41,10 @@
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000D}</UniqueIdentifier>
</Filter>
<Filter Include="src\messages\peer\enums">
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000F}</UniqueIdentifier>
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-000000000001}</UniqueIdentifier>
</Filter>
<Filter Include="src\messages\variant">
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-00000000000E}</UniqueIdentifier>
</Filter>
<Filter Include="src\net">
<UniqueIdentifier>{D28FC18A-8B81-4247-0000-000000000006}</UniqueIdentifier>
Expand Down Expand Up @@ -135,12 +138,6 @@
<ClCompile Include="..\..\..\..\test\memory.cpp">
<Filter>src</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\body_reader.cpp">
<Filter>src\messages\http</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\body_writer.cpp">
<Filter>src\messages\http</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\enums\magic_numbers.cpp">
<Filter>src\messages\http\enums</Filter>
</ClCompile>
Expand All @@ -153,7 +150,10 @@
<ClCompile Include="..\..\..\..\test\messages\http\fields.cpp">
<Filter>src\messages\http</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\method.cpp">
<ClCompile Include="..\..\..\..\test\messages\http\head_reader.cpp">
<Filter>src\messages\http</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\http\head_writer.cpp">
<Filter>src\messages\http</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\json\body_reader.cpp">
Expand Down Expand Up @@ -297,6 +297,21 @@
<ClCompile Include="..\..\..\..\test\messages\peer\witness_tx_id_relay.cpp">
<Filter>src\messages\peer</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\body_reader.cpp">
<Filter>src\messages\variant</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\body_writer.cpp">
<Filter>src\messages\variant</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\head_reader.cpp">
<Filter>src\messages\variant</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\head_writer.cpp">
<Filter>src\messages\variant</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\messages\variant\method.cpp">
<Filter>src\messages\variant</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\net.cpp">
<Filter>src</Filter>
</ClCompile>
Expand Down
23 changes: 15 additions & 8 deletions builds/msvc/vs2022/libbitcoin-network/libbitcoin-network.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,12 @@
<ClCompile Include="..\..\..\..\src\log\logger.cpp" />
<ClCompile Include="..\..\..\..\src\log\reporter.cpp" />
<ClCompile Include="..\..\..\..\src\memory.cpp" />
<ClCompile Include="..\..\..\..\src\messages\http\body.cpp">
<ObjectFileName>$(IntDir)src_messages_http_body.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\src\messages\http\enums\mime_type.cpp" />
<ClCompile Include="..\..\..\..\src\messages\http\enums\target.cpp" />
<ClCompile Include="..\..\..\..\src\messages\http\fields.cpp" />
<ClCompile Include="..\..\..\..\src\messages\http\head.cpp">
<ObjectFileName>$(IntDir)src_messages_http_head.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\src\messages\json\body.cpp">
<ObjectFileName>$(IntDir)src_messages_json_body.obj</ObjectFileName>
</ClCompile>
Expand Down Expand Up @@ -192,6 +192,12 @@
<ClCompile Include="..\..\..\..\src\messages\peer\version.cpp" />
<ClCompile Include="..\..\..\..\src\messages\peer\version_acknowledge.cpp" />
<ClCompile Include="..\..\..\..\src\messages\peer\witness_tx_id_relay.cpp" />
<ClCompile Include="..\..\..\..\src\messages\variant\body.cpp">
<ObjectFileName>$(IntDir)src_messages_variant_body.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\src\messages\variant\head.cpp">
<ObjectFileName>$(IntDir)src_messages_variant_head.obj</ObjectFileName>
</ClCompile>
<ClCompile Include="..\..\..\..\src\net.cpp" />
<ClCompile Include="..\..\..\..\src\net\acceptor.cpp" />
<ClCompile Include="..\..\..\..\src\net\broadcaster.cpp" />
Expand Down Expand Up @@ -265,7 +271,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\network\log\timer.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\log\tracker.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\memory.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\body.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\enums\magic_numbers.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\enums\mime_type.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\enums\status.hpp" />
Expand All @@ -274,10 +279,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\fields.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\head.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\http.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\method.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\request.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\response.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\http\types.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\json\body.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\json\json.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\peer\address.hpp" />
Expand Down Expand Up @@ -326,6 +327,12 @@
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\peer\version.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\peer\version_acknowledge.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\peer\witness_tx_id_relay.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\variant\body.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\variant\head.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\variant\method.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\variant\request.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\variant\response.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\messages\variant\variant.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\net.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\net\acceptor.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\network\net\broadcaster.hpp" />
Expand Down
Loading
Loading