Skip to content

Add if_common_type<> (and is_common_type, is_base_type), tests. #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Add if_common_type<> (and is_common_type, is_base_type), tests. #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/bitcoin/system/constraints.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ template <typename Base, typename Type>
using if_not_base_of = bool_if<
!std::is_base_of<Base, Type>::value>;

template <typename Left, typename Right>
using if_common_type = bool_if<
is_common_type<Left, Right>>;

template <typename Left, typename Right>
using if_same_size = bool_if<
is_same_size<Left, Right>>;
Expand Down
13 changes: 11 additions & 2 deletions include/bitcoin/system/typelets.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ template <typename Left, typename Right>
constexpr bool is_same_type = std::is_same_v<std::decay_t<Left>,
std::decay_t<Right>>;

/// Left is base class of Right, independent of const and volatility.
template <typename Left, typename Right>
constexpr bool is_base_type = std::is_base_of_v<std::decay_t<Left>,
std::decay_t<Right>>;

/// Types share a common base class or are the same type.
template <typename Left, typename Right>
constexpr bool is_common_type = is_base_type<Left, Right> ||
is_base_type<Right, Left>;

/// Alias - bool is unsigned: bool(-1) < bool(0). w/char sign unspecified.
/// w/charxx_t types are unsigned. iostream relies on w/char.
template <typename Type>
Expand Down Expand Up @@ -76,8 +86,7 @@ constexpr bool is_integral_integer = is_integral<Type> /*&& is_integer<Type>*/;

/// numeric_limits may be specialized by non-integrals (such as uintx).
template <typename Type>
constexpr bool is_floating_point =
std::is_floating_point_v<std::decay_t<Type>>;
constexpr bool is_floating_point = std::is_floating_point_v<std::decay_t<Type>>;

/// Constrained to is_integral types.
template <typename Type, std::enable_if_t<is_integral_size<Type>, bool> = true>
Expand Down
124 changes: 63 additions & 61 deletions test/constraints.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,21 @@
*/
#include "test.hpp"


// helpers

typedef bool non_constant;
typedef const bool constant;
class base {};
class not_default_constructible { not_default_constructible(int) {} };

class not_derived {};
class base {};
class derived : base {};
////class not_default_constructible { not_default_constructible(int) {}};
class more_derived : derived {};
class also_derived : base {};
class more_also_derived : also_derived {};

template <typename>
constexpr bool is_defined = true;
template <typename Type>
constexpr bool is_defined = !std::is_void_v<Type>;

// sizes

Expand Down Expand Up @@ -129,16 +132,16 @@ static_assert(is_defined<if_not_same<char, bool>>);

static_assert(is_defined<if_one_byte<int8_t>>);
static_assert(is_defined<if_one_byte<uint8_t>>);
////static_assert(is_defined<if_one_byte<char>>);
////static_assert(is_defined<if_one_byte<bool>>);
static_assert(is_defined<if_one_byte<char>>);
static_assert(is_defined<if_one_byte<bool>>);
////static_assert(!is_defined<if_one_byte<uint256_t>>);
////static_assert(!is_defined<if_one_byte<float>>);
////static_assert(!is_defined<if_one_byte<double>>);
////static_assert(!is_defined<if_one_byte<int16_t>>);
////static_assert(!is_defined<if_one_byte<uint32_t>>);
////static_assert(!is_defined<if_one_byte<int64_t>>);
////static_assert(!is_defined<if_one_byte<size_t>>);
////static_assert(!is_defined<if_one_byte<base>>);
////////static_assert(!is_defined<if_one_byte<base>>);

static_assert(is_defined<if_not_one_byte<int16_t>>);
static_assert(is_defined<if_not_one_byte<uint32_t>>);
Expand All @@ -164,10 +167,10 @@ static_assert(is_defined<if_size_of<signed_size_t, sizeof(size_t)>>);
////static_assert(!is_defined<if_size_of<int, sizeof(bool)>>);

static_assert(is_defined<if_const<constant>>);
////static_assert(!is_defined<if_const<is_non_constant>>);
////static_assert(!is_defined<if_const<non_constant>>);

static_assert(is_defined<if_non_const<non_constant>>);
////static_assert(!is_defined<if_non_const<is_constant>>);
////static_assert(!is_defined<if_non_const<constant>>);

static_assert(is_defined<if_base_of<base, base>>);
static_assert(is_defined<if_base_of<base, derived>>);
Expand All @@ -183,6 +186,19 @@ static_assert(is_defined<if_not_base_of<float, double>>);
////static_assert(!is_defined<if_not_base_of<base, base>>);
////static_assert(!is_defined<if_not_base_of<base, derived>>);

static_assert(is_defined<if_common_type<base, base>>);
static_assert(is_defined<if_common_type<base, derived>>);
static_assert(is_defined<if_common_type<derived, derived>>);
static_assert(is_defined<if_common_type<derived, base>>);
static_assert(is_defined<if_common_type<derived, more_derived>>);
static_assert(is_defined<if_common_type<more_derived, derived>>);
static_assert(is_defined<if_common_type<also_derived, more_also_derived>>);
static_assert(is_defined<if_common_type<more_also_derived, also_derived>>);
////static_assert(!is_defined<if_common_type<derived, also_derived>>);
////static_assert(!is_defined<if_common_type<also_derived, derived>>);
////static_assert(!is_defined<if_common_type<base, not_derived>>);
////static_assert(!is_defined<if_common_type<not_derived, base>>);

static_assert(is_defined<if_same_size<bool, bool>>);
static_assert(is_defined<if_same_size<int, int>>);
static_assert(is_defined<if_same_size<int8_t, int8_t>>);
Expand All @@ -202,10 +218,6 @@ static_assert(is_defined<if_same_size<uint64_t, int64_t>>);
////static_assert(!is_defined<if_same_size<int16_t, int32_t>>);
////static_assert(!is_defined<if_same_size<int16_t, int64_t>>);
////static_assert(!is_defined<if_same_size<int32_t, int64_t>>);
////static_assert(is_defined<if_same_size<int, uint32_t>>);
////static_assert(is_defined<if_same_size<int32_t, int>>);
////static_assert(!is_defined<if_same_size<bool, int>>);
////static_assert(!is_defined<if_same_size<int, bool>>);

static_assert(is_defined<if_not_same_size<int8_t, int16_t>>);
static_assert(is_defined<if_not_same_size<int8_t, int32_t>>);
Expand All @@ -216,28 +228,23 @@ static_assert(is_defined<if_not_same_size<int8_t, int64_t>>);
static_assert(is_defined<if_not_same_size<int16_t, int32_t>>);
static_assert(is_defined<if_not_same_size<int16_t, int64_t>>);
static_assert(is_defined<if_not_same_size<int32_t, int64_t>>);
////static_assert(is_defined<if_not_same_size<bool, bool>>);
////static_assert(is_defined<if_not_same_size<int, int>>);
////static_assert(is_defined<if_not_same_size<int8_t, int8_t>>);
////static_assert(is_defined<if_not_same_size<uint8_t, uint8_t>>);
////static_assert(is_defined<if_not_same_size<int16_t, uint16_t>>);
////static_assert(is_defined<if_not_same_size<uint16_t, int16_t>>);
////static_assert(is_defined<if_not_same_size<int32_t, uint32_t>>);
////static_assert(is_defined<if_not_same_size<uint32_t, int32_t>>);
////static_assert(is_defined<if_not_same_size<int64_t, uint64_t>>);
////static_assert(is_defined<if_not_same_size<uint64_t, int64_t>>);
////static_assert(is_defined<if_not_same_size<int, uint32_t>>);
////static_assert(is_defined<if_not_same_size<int32_t, int>>);
////static_assert(is_defined<if_not_same_size<bool, int>>);
////static_assert(is_defined<if_not_same_size<int, bool>>);

////static_assert(!is_defined<if_not_same_size<int8_t, int8_t>>);
////static_assert(!is_defined<if_not_same_size<uint8_t, uint8_t>>);
////static_assert(!is_defined<if_not_same_size<int16_t, uint16_t>>);
////static_assert(!is_defined<if_not_same_size<uint16_t, int16_t>>);
////static_assert(!is_defined<if_not_same_size<int32_t, uint32_t>>);
////static_assert(!is_defined<if_not_same_size<uint32_t, int32_t>>);
////static_assert(!is_defined<if_not_same_size<int64_t, uint64_t>>);
////static_assert(!is_defined<if_not_same_size<uint64_t, int64_t>>);

static_assert(is_defined<if_lesser_size<int8_t, int16_t>>);
static_assert(is_defined<if_lesser_size<int8_t, int32_t>>);
static_assert(is_defined<if_lesser_size<int8_t, int64_t>>);
static_assert(is_defined<if_lesser_size<int16_t, int32_t>>);
static_assert(is_defined<if_lesser_size<int16_t, int64_t>>);
static_assert(is_defined<if_lesser_size<int32_t, int64_t>>);
////static_assert(is_defined<if_lesser_size<bool, int>>);
static_assert(is_defined<if_lesser_size<bool, int>>);
////static_assert(!is_defined<if_lesser_size<bool, bool>>);
////static_assert(!is_defined<if_lesser_size<int, int>>);
////static_assert(!is_defined<if_lesser_size<int, uint32_t>>);
Expand Down Expand Up @@ -271,7 +278,7 @@ static_assert(is_defined<if_not_lesser_size<int32_t, uint32_t>>);
static_assert(is_defined<if_not_lesser_size<uint32_t, int32_t>>);
static_assert(is_defined<if_not_lesser_size<int64_t, uint64_t>>);
static_assert(is_defined<if_not_lesser_size<uint64_t, int64_t>>);
////static_assert(is_defined<if_not_lesser_size<int, bool>>);
static_assert(is_defined<if_not_lesser_size<int, bool>>);
////static_assert(!is_defined<if_not_lesser_size<bool, int>>);
////static_assert(!is_defined<if_not_lesser_size<int8_t, int16_t>>);
////static_assert(!is_defined<if_not_lesser_size<int8_t, int32_t>>);
Expand All @@ -286,20 +293,16 @@ static_assert(is_defined<if_greater_size<int64_t, int8_t>>);
static_assert(is_defined<if_greater_size<int32_t, int16_t>>);
static_assert(is_defined<if_greater_size<int64_t, int16_t>>);
static_assert(is_defined<if_greater_size<int64_t, int32_t>>);
////static_assert(is_defined<if_greater_size<bool, int>>);
////static_assert(is_defined<if_greater_size<bool, bool>>);
////static_assert(is_defined<if_greater_size<int, int>>);
////static_assert(is_defined<if_greater_size<int, uint32_t>>);
////static_assert(is_defined<if_greater_size<int32_t, int>>);
////static_assert(is_defined<if_greater_size<int8_t, int8_t>>);
////static_assert(is_defined<if_greater_size<uint8_t, uint8_t>>);
////static_assert(is_defined<if_greater_size<int16_t, uint16_t>>);
////static_assert(is_defined<if_greater_size<uint16_t, int16_t>>);
////static_assert(is_defined<if_greater_size<int32_t, uint32_t>>);
////static_assert(is_defined<if_greater_size<uint32_t, int32_t>>);
////static_assert(is_defined<if_greater_size<int64_t, uint64_t>>);
////static_assert(is_defined<if_greater_size<uint64_t, int64_t>>);
////static_assert(is_defined<if_greater_size<int, bool>>);
////static_assert(!is_defined<if_greater_size<bool, bool>>);
////static_assert(!is_defined<if_greater_size<int, int>>);
////static_assert(!is_defined<if_greater_size<int8_t, int8_t>>);
////static_assert(!is_defined<if_greater_size<uint8_t, uint8_t>>);
////static_assert(!is_defined<if_greater_size<int16_t, uint16_t>>);
////static_assert(!is_defined<if_greater_size<uint16_t, int16_t>>);
////static_assert(!is_defined<if_greater_size<int32_t, uint32_t>>);
////static_assert(!is_defined<if_greater_size<uint32_t, int32_t>>);
////static_assert(!is_defined<if_greater_size<int64_t, uint64_t>>);
////static_assert(!is_defined<if_greater_size<uint64_t, int64_t>>);

static_assert(is_defined<if_not_greater_size<bool, bool>>);
static_assert(is_defined<if_not_greater_size<uint8_t, bool>>);
Expand All @@ -320,8 +323,6 @@ static_assert(is_defined<if_not_greater_size<int32_t, uint32_t>>);
static_assert(is_defined<if_not_greater_size<uint32_t, int32_t>>);
static_assert(is_defined<if_not_greater_size<int64_t, uint64_t>>);
static_assert(is_defined<if_not_greater_size<uint64_t, int64_t>>);
////static_assert(!is_defined<if_not_greater_size<bool, int>>);
////static_assert(!is_defined<if_not_greater_size<int, bool>>);
////static_assert(!is_defined<if_not_greater_size<int16_t, int8_t>>);
////static_assert(!is_defined<if_not_greater_size<int32_t, int8_t>>);
////static_assert(!is_defined<if_not_greater_size<int64_t, int8_t>>);
Expand All @@ -347,14 +348,14 @@ static_assert(is_defined<if_default_constructible<std_array<bool, 42>>>);
////static_assert(!is_defined<if_default_constructible<not_default_constructible>>);

static_assert(is_defined<if_trivially_constructible<uint32_t>>);
////static_assert(is_defined<if_trivially_constructible<std_vector<uint8_t>>>);
static_assert(is_defined<if_trivially_constructible<std::array<uint8_t, 42>>>);
////static_assert(!is_defined<if_trivially_constructible<std::string>>);
static_assert(is_defined<if_trivially_constructible<std_array<uint8_t, 42>>>);
////static_assert(!is_defined<if_trivially_constructible<std::vector<uint8_t>>>);
////static_assert(!is_defined<if_trivially_constructible<not_default_constructible>>);

static_assert(is_defined<if_unique_object_representations<bool>>);
static_assert(is_defined<if_unique_object_representations<size_t>>);
//static_assert(!is_defined<if_unique_object_representations<std::string>>);
////static_assert(!is_defined<if_unique_object_representations<std::string>>);
////static_assert(!is_defined<if_unique_object_representations<base>>);
////static_assert(!is_defined<if_unique_object_representations<derived>>);

Expand Down Expand Up @@ -389,7 +390,7 @@ static_assert(is_defined<if_signed_integer<int>>);
static_assert(is_defined<if_signed_integer<int16_t>>);
static_assert(is_defined<if_signed_integer<int32_t>>);
static_assert(is_defined<if_signed_integer<int64_t>>);
////static_assert(is_defined<if_signed_integer<uintx>>);
////static_assert(!is_defined<if_signed_integer<uintx>>);
////static_assert(!is_defined<if_signed_integer<bool>>);
////static_assert(!is_defined<if_signed_integer<float>>);
////static_assert(!is_defined<if_signed_integer<double>>);
Expand Down Expand Up @@ -441,15 +442,15 @@ static_assert(is_defined<if_same_signed_integer<unsigned char, uint8_t>>);
static_assert(is_defined<if_same_signed_integer<uint8_t, uint8_t>>);
static_assert(is_defined<if_same_signed_integer<uint32_t, uint32_t>>);
static_assert(is_defined<if_same_signed_integer<uint64_t, uint64_t>>);
////static_assert(is_defined<if_same_signed_integer<bool, bool>>);
////static_assert(!is_defined<if_same_signed_integer<bool, bool>>);
////static_assert(!is_defined<if_same_signed_integer<float, float>>);
////static_assert(!is_defined<if_same_signed_integer<double, double>>);
////static_assert(!is_defined<if_same_signed_integer<base, base>>);

static_assert(is_defined<if_same_signed_integer<uint16_t, uint8_t>>);
static_assert(is_defined<if_same_signed_integer<uint8_t, unsigned char>>);
static_assert(is_defined<if_same_signed_integer<unsigned char, uint8_t>>);
////static_assert(is_defined<if_same_signed_integer<int, char>>);
static_assert(is_defined<if_same_signed_integer<int, char>>);
////static_assert(!is_defined<if_same_signed_integer<int16_t, bool>>);
////static_assert(!is_defined<if_same_signed_integer<uint16_t, bool>>);
////static_assert(!is_defined<if_same_signed_integer<char, unsigned char>>);
Expand Down Expand Up @@ -491,8 +492,8 @@ static_assert(is_defined<if_uintx<uint512_t>>);
////static_assert(!is_defined<if_uintx<base>>);
////static_assert(!is_defined<if_uintx<std_array<uint8_t, 42>>>);

// integral integer types
// bool is considered non-integral.
// integral integer types
// bool is considered non-integral.

static_assert(is_defined<if_integral<char>>);
static_assert(is_defined<if_integral<int>>);
Expand Down Expand Up @@ -559,7 +560,7 @@ static_assert(is_defined<if_unsigned_integral_integer<uint8_t>>);

static_assert(is_defined<if_same_signed_integral_integer<int, signed char>>);
static_assert(is_defined<if_same_signed_integral_integer<uint16_t, uint8_t>>);
////static_assert(is_defined<if_same_signed_integral_integer<uintx, uint256_t>>);
////static_assert(!is_defined<if_same_signed_integral_integer<uintx, uint256_t>>);
////static_assert(!is_defined<if_same_signed_integral_integer<uint16_t, bool>>);
////static_assert(!is_defined<if_same_signed_integral_integer<size_t, bool>>);
////static_assert(!is_defined<if_same_signed_integral_integer<bool, bool>>);
Expand Down Expand Up @@ -588,15 +589,15 @@ static_assert(is_defined<if_same_signed_integral_integer<unsigned char, uint8_t>
static_assert(is_defined<if_same_signed_integral_integer<uint8_t, uint8_t>>);
static_assert(is_defined<if_same_signed_integral_integer<uint32_t, uint32_t>>);
static_assert(is_defined<if_same_signed_integral_integer<uint64_t, uint64_t>>);
////static_assert(is_defined<if_same_signed_integral_integer<bool, bool>>);
////static_assert(!is_defined<if_same_signed_integral_integer<bool, bool>>);
////static_assert(!is_defined<if_same_signed_integral_integer<float, float>>);
////static_assert(!is_defined<if_same_signed_integral_integer<double, double>>);
////static_assert(!is_defined<if_same_signed_integral_integer<base, base>>);

static_assert(is_defined<if_same_signed_integral_integer<uint16_t, uint8_t>>);
static_assert(is_defined<if_same_signed_integral_integer<uint8_t, unsigned char>>);
static_assert(is_defined<if_same_signed_integral_integer<unsigned char, uint8_t>>);
////static_assert(is_defined<if_same_signed_integral_integer<int, char>>);
static_assert(is_defined<if_same_signed_integral_integer<int, char>>);
////static_assert(!is_defined<if_same_signed_integral_integer<int16_t, bool>>);
////static_assert(!is_defined<if_same_signed_integral_integer<uint16_t, bool>>);
////static_assert(!is_defined<if_same_signed_integral_integer<char, unsigned char>>);
Expand All @@ -606,7 +607,7 @@ static_assert(is_defined<if_not_same_signed_integral_integer<uint16_t, int>>);
static_assert(is_defined<if_not_same_signed_integral_integer<size_t, int>>);
static_assert(is_defined<if_not_same_signed_integral_integer<int, uint16_t>>);
static_assert(is_defined<if_not_same_signed_integral_integer<int, size_t>>);
////static_assert(is_defined<if_not_same_signed_integral_integer<uintx, uint256_t>>);
////static_assert(!is_defined<if_not_same_signed_integral_integer<uintx, uint256_t>>);
////static_assert(!is_defined<if_not_same_signed_integral_integer<int, char>>);
////static_assert(!is_defined<if_not_same_signed_integral_integer<uint16_t, uint8_t>>);
////static_assert(!is_defined<if_not_same_signed_integral_integer<bool, int>>);
Expand All @@ -619,8 +620,8 @@ static_assert(is_defined<if_not_same_signed_integral_integer<int, size_t>>);
////static_assert(!is_defined<if_not_same_signed_integral_integer<int64_t, int>>);
////static_assert(!is_defined<if_not_same_signed_integral_integer<base, int>>);

////static_assert(is_defined<if_big_endian_integral_integer<uint8_t>>);
////static_assert(is_defined<if_little_endian_integral_integer<uint8_t>>);
////static_assert(is_little_endian || is_defined<if_big_endian_integral_integer<uint8_t>>);
////static_assert(is_big_endian || is_defined<if_little_endian_integral_integer<uint8_t>>);

////static_assert(!is_defined<if_floating_point<int>>);
////static_assert(!is_defined<if_floating_point<bool>>);
Expand All @@ -647,7 +648,8 @@ static_assert(is_defined<if_integral_array<std_array<uint8_t, 0>>>);
static_assert(is_defined<if_byte_insertable<std::string>>);
static_assert(is_defined<if_byte_insertable<std::vector<uint8_t>>>);
static_assert(is_defined<if_byte_insertable<std_vector<uint8_t>>>);
////static_assert(is_defined<if_byte_insertable<std_array<uint8_t, 42>>>);
////static_assert(!is_defined<if_byte_insertable<std_array<uint8_t, 42>>>);
////static_assert(!is_defined<if_byte_insertable<std::array<uint8_t, 42>>>);
////static_assert(!is_defined<if_byte_insertable<std::u32string>>);
////static_assert(!is_defined<if_byte_insertable<std_vector<uint32_t>>>);
////static_assert(!is_defined<if_byte_insertable<uint32_t>>);
22 changes: 22 additions & 0 deletions test/typelets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
class base {};
class not_derived {};
class derived : base {};
class also_derived : base {};
class more_derived : also_derived {};

// These are implementation defined.
////static_assert(is_same_type<unsigned char, uint8_t>);
Expand Down Expand Up @@ -55,6 +57,26 @@ static_assert(!is_same_type<base, derived>);
static_assert(!is_same_type<base, not_derived>);
static_assert(is_same_type<decltype(is_same_type<int32_t, int32_t>), const bool>);

// Classes only for derivation.
static_assert(!is_base_type<uint8_t, uint8_t>);
static_assert(is_base_type<base, base>);
static_assert(is_base_type<base, derived>);
static_assert(is_base_type<base, also_derived>);
static_assert(is_base_type<base, more_derived>);
static_assert(!is_base_type<base, not_derived>);

// Classes only for derivation.
static_assert(!is_common_type<uint8_t, uint8_t>);
static_assert(is_common_type<base, base>);
static_assert(is_common_type<base, derived>);
static_assert(is_common_type<base, also_derived>);
static_assert(is_common_type<base, more_derived>);
static_assert(!is_common_type<base, not_derived>);
static_assert(!is_common_type<more_derived, not_derived>);
static_assert(!is_common_type<not_derived, more_derived>);
static_assert(is_common_type<more_derived, also_derived>);
static_assert(is_common_type<also_derived, more_derived>);

// These are implementation defined.
////static_assert(is_signed<char>);
////static_assert(!is_signed<wchar_t>);
Expand Down
Loading