Skip to content

Allow functions with just two namespace levels #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2019
Merged

Allow functions with just two namespace levels #32

merged 2 commits into from
Feb 18, 2019

Conversation

@carlosmn
Copy link
Member

@carlosmn carlosmn commented Feb 18, 2019

Functions like git_cherrypick should be in the cherrypick group even though it doesn't have a third level of namespacing.

tiennou and others added 2 commits February 18, 2019 21:52
@tiennou @carlosmn
Fix grouping bug with namespc_name-style functions
360629a 
Previously, function akin to `git_clone` would get part of their input file path appended, yielding `git2_clone` as the group.
@carlosmn
test: detect git_cherrypick creates a 'cherrypick' group
58d5bb1
@carlosmn carlosmn merged commit 8a730ff into master Feb 18, 2019
@carlosmn carlosmn deleted the cmn/two-levels branch February 18, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosmn @tiennou