-
Notifications
You must be signed in to change notification settings - Fork 22
Switch to Github Actions for CI #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| name: Ruby ${{ matrix.ruby }} on ${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| continue-on-error: ${{ endsWith(matrix.ruby, 'head') || matrix.ruby == 'debug' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "debug" left over from some other testing? Is the endsWith necessary? Wouldn't matrix.ruby match head exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a verbatim copy-paste from the documentation, where there's much more than MRI Ruby handled. I'm tempted to keep it as-is for future-proofing, but I'll gladly defer to your preference.
|
Updated to have builds against multiple LLVM versions. I've moved the macOS build out of the matrix so we don't end up with 40+ jobs as well. Looks like the PR picked up the workflow already 👍. |
|
It looks like Ruby 2.6 sometimes fails to grab all the groups, but somewhat inconsistently. I wonder what's up with that and whether it's something we need to/can fix. |
|
Yeah, I suspect it's spotty because of stuff like I have a patch that implements a retry loop around that to alleviate this issue, and I might upstream it separately. |
This moves all our CI infrastructure over to Github Actions and removes Travis from the equation, with a matrix of Ubuntu/macOS vs. Ruby 2.4/2.5/2.6/head.
Note that I cherrypicked one commit from #56 to handle Ruby 3/
head, and that I've run the actions while pushing to my fork'smasterbranch — see here for the runs.Loosely inspired from #47 (had an issue with finding libclang on Linux).