Rename methods with Get prefix #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thank you for the corrections 👍 |
lhchavez
reviewed
May 10, 2020
Contributor
lhchavez
left a comment
lhchavez
left a comment
There was a problem hiding this comment.
since I can't squash this commit, do you mind doing that? otherwise looks good!
It is not Go idiomatic to put Get into the getter's name. https: //golang.org/doc/effective_go.html#Getters Co-Authored-By: lhchavez <lhchavez@users.noreply.github.com>
suhaibmujahid
force-pushed
the
method-rename
branch
from
0ca363a to
cf6522c
Compare
Contributor
Author
|
Done! |
lhchavez
added a commit
that referenced
this pull request
Aug 15, 2020
It is not Go idiomatic to put Get into the getter's name (cherry picked from commit 31f877e)
lhchavez
added a commit
that referenced
this pull request
Aug 15, 2020
It is not Go idiomatic to put Get into the getter's name (cherry picked from commit 31f877e)
lhchavez
added a commit
that referenced
this pull request
Aug 15, 2020
It is not Go idiomatic to put Get into the getter's name (cherry picked from commit 31f877e)
lhchavez
added a commit
that referenced
this pull request
Aug 15, 2020
It is not Go idiomatic to put Get into the getter's name (cherry picked from commit 31f877e)
lhchavez
added a commit
that referenced
this pull request
Aug 16, 2020
It is not Go idiomatic to put Get into the getter's name (cherry picked from commit 31f877e)
lhchavez
added a commit
that referenced
this pull request
Aug 16, 2020
It is not Go idiomatic to put Get into the getter's name (cherry picked from commit 31f877e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not Go idiomatic to put Get into the getter's name (see here).
Based on the discussion with @lhchavez on Slack. He suggested the renaming and adding backward compatibility.