Skip to content

Conversation

@suhaibmujahid
Copy link
Contributor

The libgit2 v1.1.0 is released two weeks ago. This PR allows git2go to link against the new version.

@suhaibmujahid suhaibmujahid marked this pull request as ready for review October 26, 2020 13:44
Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :D

@lhchavez lhchavez merged commit ad3ec36 into libgit2:master Oct 27, 2020
@suhaibmujahid
Copy link
Contributor Author

Thank you for merging this.

I think the automatically generated version tag is not correct.

See here: https://github.com/libgit2/git2go/releases/tag/v30.0.19

It should be v31 not v30. I think it should be deleted to not crash for ppl that depend on the older libgit2 version.

Based on the documentation of the action that we are using:
https://github.com/anothrNick/github-tag-action#bumping
I supposed to include #major in the commit message to bump a major version.

@lhchavez
Copy link
Contributor

Thank you for merging this.

I think the automatically generated version tag is not correct.

See here: https://github.com/libgit2/git2go/releases/tag/v30.0.19

It should be v31 not v30. I think it should be deleted to not crash for ppl that depend on the older libgit2 version.

Based on the documentation of the action that we are using:
https://github.com/anothrNick/github-tag-action#bumping
I supposed to include #major in the commit message to bump a major version.

oops, thanks for noticing! new tags and the new release-1.1 branch have been created.

@suhaibmujahid
Copy link
Contributor Author

Thank you for the fast response.

I believe that the tag v30.0.19 should be deleted (or create v30.0.20 on the commit f83530b). Otherwise when someone updates or installs v30, by default will get v30.0.19 which depends on an unexpected libgit2 version.

@lhchavez
Copy link
Contributor

Thank you for the fast response.

I believe that the tag v30.0.19 should be deleted (or create v30.0.20 on the commit f83530b). Otherwise when someone updates or installs v30, by default will get v30.0.19 which depends on an unexpected libgit2 version.

the tag was also deleted when the v31 tag was created. the only thing left was the github release, which is not a real tag (but that's also removed now to avoid confusion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants