Prefer GetRandomFileName() over NewGuid() for paths

Author: nulltoken

LibGit2Sharp.Tests/ArchiveTarFixture.cs

@@ -26,7 +26,7 @@ public void CanArchiveACommitWithDirectoryAsTar()
                 var commit = repo.Lookup<Commit>("4c062a6361ae6959e06292c1fa5e2822d9c96345");
 
                 var scd = BuildSelfCleaningDirectory();
-                var archivePath = Path.Combine(scd.RootedDirectoryPath, Guid.NewGuid() + ".tar");
+                var archivePath = Path.Combine(scd.RootedDirectoryPath, Path.GetRandomFileName() + ".tar");
                 Directory.CreateDirectory(scd.RootedDirectoryPath);
 
                 repo.ObjectDatabase.Archive(commit, archivePath);

LibGit2Sharp.Tests/CloneFixture.cs

@@ -92,7 +92,7 @@ public void CanCloneALocalRepositoryFromAStandardPath()
         [Fact]
         public void CanCloneALocalRepositoryFromANewlyCreatedTemporaryPath()
         {
-            var path = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString().Substring(0, 8));
+            var path = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
             SelfCleaningDirectory scd = BuildSelfCleaningDirectory(path);
             Repository.Init(scd.DirectoryPath);
             AssertLocalClone(scd.DirectoryPath, isCloningAnEmptyRepository: true);

LibGit2Sharp.Tests/CommitFixture.cs

@@ -831,7 +831,7 @@ public void CanAmendACommitWithMoreThanOneParent()
 
         private static void CreateAndStageANewFile(IRepository repo)
         {
-            string relativeFilepath = string.Format("new-file-{0}.txt", Guid.NewGuid());
+            string relativeFilepath = string.Format("new-file-{0}.txt", Path.GetRandomFileName());
             Touch(repo.Info.WorkingDirectory, relativeFilepath, "brand new content\n");
             repo.Stage(relativeFilepath);
         }

LibGit2Sharp.Tests/PushFixture.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 using System.Linq;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
@@ -159,7 +160,7 @@ private void UpdateTheRemoteRepositoryWithANewCommit(string remoteRepoPath)
         private Commit AddCommitToRepo(IRepository repository)
         {
 
-            string random = Guid.NewGuid().ToString();
+            string random = Path.GetRandomFileName();
             string filename = random + ".txt";
 
             Touch(repository.Info.WorkingDirectory, filename, random);

LibGit2Sharp.Tests/RepositoryFixture.cs

@@ -543,14 +543,11 @@ public void CanDiscoverAStandardRepoGivenTheWorkingDirPath()
         [Fact]
         public void DiscoverReturnsNullWhenNoRepoCanBeFound()
         {
-            string path = Path.GetTempFileName();
-            string suffix = "." + Guid.NewGuid().ToString().Substring(0, 7);
+            string path = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
 
-            SelfCleaningDirectory scd = BuildSelfCleaningDirectory(path + suffix);
+            SelfCleaningDirectory scd = BuildSelfCleaningDirectory(path);
             Directory.CreateDirectory(scd.RootedDirectoryPath);
             Assert.Null(Repository.Discover(scd.RootedDirectoryPath));
-
-            File.Delete(path);
         }
 
         [Fact]

LibGit2Sharp.Tests/ShadowCopyFixture.cs

@@ -17,7 +17,7 @@ public void CanProbeForNativeBinariesFromAShadowCopiedAssembly()
             Assembly assembly = type.Assembly;
 
             // Build a new domain which will shadow copy assemblies
-            string cachePath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+            string cachePath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
             Directory.CreateDirectory(cachePath);
 
             var setup = new AppDomainSetup

LibGit2Sharp.Tests/TestHelpers/SelfCleaningDirectory.cs

@@ -28,7 +28,7 @@ public SelfCleaningDirectory(IPostTestDirectoryRemover directoryRemover, string
 
         protected static string BuildTempPath()
         {
-            return Path.Combine(Constants.TemporaryReposPath, Guid.NewGuid().ToString().Substring(0, 8));
+            return Path.Combine(Constants.TemporaryReposPath, Path.GetRandomFileName());
         }
     }
 }