Replace Global Filter Object with a Factory Model #1240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardized the exposed virtual entry-points. Combined Clean and Smudge entry-points. Moved all long-term constructs into FilterRegister. Removed the superfluous FilterAttributeEntry. Refactored to only support single attribute filters. Fixed up tests to use new model. Sanity checked and rationalized substitution cipher filter tests.
|
/CC @nulltoken |
…ing odb <-> workdir operations.
|
It looks like there's overlap with #1260 which we didn't realise when merging that. Is this (or parts of this) still needed? |
They do overlap when considering the ability to run multiple streams simultaneously, but the semantics presented here are "cleaner" imo. Additionally, this version only keeps the registration itself persistent and invokes a new instance per invocation of the filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Filter to a short lived, per-file entity.
Standardized the exposed virtual entry-points.
Combined Clean and Smudge entry-points.
Moved all long-term constructs into
FilterRegister.Removed the superfluous
FilterAttributeEntry.Refactored to only support single attribute filters.
Added new exception type for easier identification of errors during odb <-> workdir operations.
Fixed up tests to use new model.
Sanity checked and rationalized substitution cipher filter tests.