Fix crash when running multiple filter smudge or clean operations concurrently #1260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current filter implementation in libgit2sharp stores the input/output stream pointers and more as instance variables on the
Filter
class. Unfortunately this makes it impossible to run multiple filter streams concurrently.Due to the nature of the problem manifests itself in a few different ways, sometimes as an unmanaged crash due to invalid pointer access, sometimes as a managed exception. When run under the debugger you'll sometimes get notified that a callback has been collected.
This PR changes the implementation to root the necessary references in a dictionary keyed by the stream pointer.
cc @carlosmn @ethomson