Clone recursively

[Yogu]

This implements git clone --recursive by performing the following steps:

• Clone repository normally
• For each submodule
  • Init repository with git_repository_init_ext to explicitly specify workdir and .git dir
  • git_clone_into with checkout disabled
  • Checkout the HEAD id and reset hard
  • For each submodule... (recursively)

This is a work in progress.

[Yogu]

Sometimes, native methods specify ref here for no apparent reason. Is it required here?

[ben]

Usually this is used when the native signature uses a git_oid*. GitOid is a struct on the managed side, so to get a "pointer" to it, you use ref.

Pretty sure that's how it works.

[Yogu]

Ah I see, most arguments to native methods use reference types. Curiously enough, it still works without ref.

[Yogu]

hm, travis did not find the new repository. Do I have to add new resources somewhere?

[Yogu]

What should we do if the init/update fails? I'd say, revert everything, i.e. delete the directory of the main repo.

Should we expose Submodule.Init/Update? They would need to do more checks, then.

[Yogu]

I don't know whether it is intended, but git_repository_init_ext adds a .git to the gitdirPath. It will still work, but it would be better if the repo was in .git/modules/name instead of .git/modules/name/.git/. Do you know how to achieve that?

[ben]

Looks like you can add the GIT_REPOSITORY_INIT_NO_DOTGIT_DIR flag to achieve this.

[Yogu]

Thanks!

[ben]

travis did not find the new repository

Yeah, you'll have to add your new test repo to the LibGit2Sharp.Tests/Resources directory.

[Yogu]

Thanks for your feedback, @ben!

you'll have to add your new test repo to the LibGit2Sharp.Tests/Resources directory.

I did, and it works locally, but travis says

Could not find repository from '/home/travis/build/libgit2/libgit2sharp/LibGit2Sharp.Tests/bin/Release/Resources/58f90cab-8f49-4123-a4e8-cda1488a097d/submodules.git'

Maybe that's a linux-specific problem, I can only test on Windows.

[carlosmn]

It's not anything about Linux, it's just that what you have locally is not what's in the history. The submodules.git/refs/ directory is presumably empty in your filesystem, but it's still there. Git doesn't track those, so when it's put on the filesystem on checkout, that dir is not there.

If you clone your repo locally, you should see the same error as on travis.

[Yogu]

@carlosmn Ah, thanks! That fixed it. The build still fails because of getAbsoluteUrl() which I want to get rid of eventually.

[nulltoken]

Superseded by #949

Cheers!