Teach clone to recurse into submodules

[jamill]

This is the basic outline to enable cloning with the option to recursively clone submodules. I wanted to put this up to get feedback on how the progress is reported through callbacks.

Notes:
This adds callbacks that are called before and after cloning a repository. The user has an opportunity to cancel the clone before starting a clone operation in a repository.

[jamill]

Not the biggest fan of the CurrentRepository prefix on the repository callbacks and the enum, but using it until I come up with a better name.

[jamill]

I think this could supersede #640

[nulltoken]

Can we make this internal?

[nulltoken]

Is that a reminder?

[jamill]

@nulltoken How do you feel about this? I added a new exception to indicate when an error was encountered while recursively cloning submodules.

[nulltoken]

@jamill Something weird is going on. Running the CloneFixture trashes the test runners (repo'd with TestDiven.net and Resharper). I've repro'd this as well by removing all the fixtures from the project (by CloneFixture) and running .\build.libgit2sharp.cmd in a Powershell session.

FWIW, the call stack looks suspiciously similar to #895 (comment)

/cc @ethomson

[jamill]

Unfortunate - I hadn't seen this issue before. Are we seeing this issue even without the new clone changes? Will try to take a look, but probably won't be right away.

Sent from my Windows Phone

---

From: nulltokenmailto:notifications@github.com
Sent: ý3/ý14/ý2015 9:39 AM
To: libgit2/libgit2sharpmailto:libgit2sharp@noreply.github.com
Cc: Jameson Millermailto:jamill@microsoft.com
Subject: Re: [libgit2sharp] Teach clone to recurse into submodules (#949)

@jamillhttps://github.com/jamill Something weird is going on. Running the CloneFixture trashes the test runners (repo'd with TestDiven.net and Resharper). I've repro'd this as well by removing all the fixtures from the project (by CloneFixture) and running .\build.libgit2sharp.cmd in a Powershell session.

FWIW, the call stack looks suspiciously similar to #895 (comment)#895 (comment)

[image]https://cloud.githubusercontent.com/assets/92363/6651850/a10ece06-ca57-11e4-8f01-9ae49815d92f.png

/cc @ethomsonhttps://github.com/ethomson

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/949#issuecomment-80480490.

[nulltoken]

@jamill I think it's unrelated to the clone work as the Xunit20 branch fails as well.

[nulltoken]

@jamill Ok to squash and merge?

[nulltoken]

Published as NuGet pre-release package LibGit2Sharp.0.22.0-pre20150409142943

[coveralls]

Changes Unknown when pulling b304c07 on jamill/clone_recurse_submodule into * on vNext*.