fix: replace PyList_GET_ITEM()
#1435
Open
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
2bndy5
commented
Oct 15, 2025
Comment on lines
+602
to
+607
| py_commit_oid = | ||
| #if PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION < 13 | ||
| PyList_GetItem(py_commit_oids, i); | ||
| #else | ||
| PyList_GetItemRef(py_commit_oids, i); | ||
| #endif |
There was a problem hiding this comment.
I see no .clang-format file or documented code style guidelines. So I just copied the style I observed in src/pygit2.c
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
2bndy5
force-pushed
the
replace-PyList_GET_ITEM
branch
from
158afd3 to
90569a5
Compare
resolves libgit2#1434 Instead use [`PyList_GetItem()`] for python < 3.13 or [`PyList_GetItemRef()`] for python >= 3.13. Both are part of the Stable ABI but also propagate errors. Whereas the previous [`PyList_GET_ITEM()`] did not do any error checking and was not part of the Stable ABI. [`PyList_GetItemRef()`]: https://docs.python.org/3/c-api/list.html#c.PyList_GetItemRef [`PyList_GetItem()`]: https://docs.python.org/3/c-api/list.html#c.PyList_GetItem [`PyList_GET_ITEM()`]: https://docs.python.org/3/c-api/list.html#c.PyList_GET_ITEM
2bndy5
force-pushed
the
replace-PyList_GET_ITEM
branch
from
90569a5 to
8ada517
Compare
|
PyList_GetItem returns a borrowed reference (like PyList_GET_ITEM) while PyList_GetItemRef returns a new reference, so you have to choose one, in this case use always PyList_GetItem regardless of the Python version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1434
Instead use
PyList_GetItem()for python < 3.13 orPyList_GetItemRef()for python >= 3.13.Both are part of the Stable ABI but also propagate errors. Whereas the previous
PyList_GET_ITEM()did not do any error checking and was not part of the Stable ABI.