Add in support for hex literals using underscores #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in support for hex literals with underscores for better readability. Should not change the existing behavior, but added several unit-tests to verify that the underscore literals are equivalent to non-underscore literals.
Note: in
static BigUIntView fromHexString(), we actually over-allocate for the amount of coefficients that we needmir-algorithm/source/mir/bignum/low_level_view.d
Line 572 in 085212a
This is sliced down to the amount that was actually taken here (where j represents the number of non-underscore characters)
mir-algorithm/source/mir/bignum/low_level_view.d
Line 680 in 085212a
This does increase the initial memory footprint (especially as the input string gets longer), but I haven't been able to think of a good way to get around this while keeping fromHexStringImpl @nogc. Ideally, I want to avoid iterating through the whole string twice, but that seems like the only solution that seems feasible to me.