Skip to content

fix: ignore create connection types #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

fix: ignore create connection types #120

merged 1 commit into from
Jun 30, 2025

Conversation

@achingbrain
Copy link
Member

@achingbrain achingbrain commented Jun 30, 2025

If we make the implementation match the types then errors start to occur so add ignores for now.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: ignore create connection types
51253d3 
If we make the implementation match the types then errors start to
occur so ignore them for now.
@achingbrain achingbrain merged commit 6a99d83 into main Jun 30, 2025
20 checks passed
@achingbrain achingbrain deleted the fix/types branch June 30, 2025 16:17
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@semantic-release-bot
chore(release): 1.0.4 [skip ci]
aa1a38a 
## [@libp2p/http-v1.0.4](https://github.com/libp2p/js-libp2p-http/compare/@libp2p/http-1.0.3...@libp2p/http-1.0.4) (2025-06-30)

### Bug Fixes

* ignore create connection types ([#120](#120)) ([6a99d83](6a99d83))

### Dependencies

* bump undici from 6.21.2 to 7.10.0 ([#95](#95)) ([e64c3be](e64c3be))
@github-actions
Copy link

github-actions bot commented Jun 30, 2025

🎉 This PR is included in version @libp2p/http-v1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achingbrain