fix wrong index in HandleStatePacket with flydigi controller #13819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
reviewed
Aug 28, 2025
| Sint16 axis; | ||
| Uint64 timestamp = SDL_GetTicksNS(); | ||
| if (data[0] != 0x04 && data[0] != 0xFE) { | ||
| if (data[0] != 0x04 && data[1] != 0xFE) { |
There was a problem hiding this comment.
Assuming the intention is correct (@slouken ), does && need changing to || ??
There was a problem hiding this comment.
Yep, I'll take care of it.
slouken
reviewed
Aug 28, 2025
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a wrong index checked with packet from flydigi controller.
Description
the operation packet from flydigi controller is started with 0x04 0xfe .
when handle it in function HandleStatePacket. used wrong index for check 0xfe. so when people use flydigi official application , the response ack started with 0x04 0xff will be recongized to operation wrong.