Assert that SDL_FlipMode can be used as flags
#13821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property is used internally in SDL rendering code.
slouken
reviewed
Aug 28, 2025
| SDL_FLIP_HORIZONTAL_AND_VERTICAL, /**< flip horizontally and vertically (not a diagonal flip) */ | ||
| } SDL_FlipMode; | ||
|
|
||
| SDL_COMPILE_TIME_ASSERT(SDL_FlipMode_is_flags, (SDL_FLIP_HORIZONTAL | SDL_FLIP_VERTICAL) == SDL_FLIP_HORIZONTAL_AND_VERTICAL); |
There was a problem hiding this comment.
Maybe instead of adding a compile time assert, we just define it that way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SDL_FlipModeis used internally in SDL rendering code as flags. Just grep forSDL_FLIP_HORIZONTALand see all the&and|=. This assert just adds a check so that this won't break in the future.Existing Issue(s)