blit-auto optimizations #5430
Merged
blit-auto optimizations #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@sezero : thanks for the feedback. Should be fixed now. |
|
Running the script prepends unwanted whitespace to the C source, so I |
|
In From OpenWatcom: Further warnings from gcc: |
|
@sezero : thanks again. The uninitialized variable and the indentation should be fixed. |
|
My version of perl disliked |
|
@sezero : should be fixed. |
sezero
reviewed
Mar 21, 2022
|
Works now. Style concern: it generates the C source with additional diff --git a/src/video/SDL_blit_auto.c b/src/video/SDL_blit_auto.c
index 359c1bd..d05cf68 100644
--- a/src/video/SDL_blit_auto.c
+++ b/src/video/SDL_blit_auto.c
@@ -51,3 +51,3 @@ static void SDL_Blit_RGB888_RGB888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- *dst = *src;
+ *dst = *src;
posx += incx;
@@ -758,3 +758,2 @@ static void SDL_Blit_RGB888_ARGB8888_Scale(SDL_BlitInfo *info)
const Uint32 A = 0xFF;
- Uint32 R, G, B;
int srcy, srcx;
@@ -777,6 +776,5 @@ static void SDL_Blit_RGB888_ARGB8888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- pixel = *src;
- R = (Uint8)(pixel >> 16); G = (Uint8)(pixel >> 8); B = (Uint8)pixel;
- pixel = (A << 24) | (R << 16) | (G << 8) | B;
- *dst = pixel;
+ pixel = *src;
+ pixel |= (A << 24);
+ *dst = pixel;
posx += incx;
@@ -1515,3 +1513,3 @@ static void SDL_Blit_BGR888_BGR888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- *dst = *src;
+ *dst = *src;
posx += incx;
@@ -2234,3 +2232,2 @@ static void SDL_Blit_ARGB8888_RGB888_Scale(SDL_BlitInfo *info)
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
@@ -2253,6 +2250,5 @@ static void SDL_Blit_ARGB8888_RGB888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- pixel = *src;
- R = (Uint8)(pixel >> 16); G = (Uint8)(pixel >> 8); B = (Uint8)pixel;
- pixel = (R << 16) | (G << 8) | B;
- *dst = pixel;
+ pixel = *src;
+ pixel &= 0xFFFFFF;
+ *dst = pixel;
posx += incx;
@@ -3019,3 +3015,3 @@ static void SDL_Blit_ARGB8888_ARGB8888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- *dst = *src;
+ *dst = *src;
posx += incx;
@@ -3397,3 +3393,2 @@ static void SDL_Blit_RGBA8888_RGB888_Scale(SDL_BlitInfo *info)
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
@@ -3416,6 +3411,5 @@ static void SDL_Blit_RGBA8888_RGB888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- pixel = *src;
- R = (Uint8)(pixel >> 24); G = (Uint8)(pixel >> 16); B = (Uint8)(pixel >> 8);
- pixel = (R << 16) | (G << 8) | B;
- *dst = pixel;
+ pixel = *src;
+ pixel >>= 8;
+ *dst = pixel;
posx += incx;
@@ -4165,3 +4159,3 @@ static void SDL_Blit_RGBA8888_ARGB8888_Scale(SDL_BlitInfo *info)
Uint32 pixel;
- Uint32 R, G, B, A;
+ Uint32 A;
int srcy, srcx;
@@ -4184,6 +4178,5 @@ static void SDL_Blit_RGBA8888_ARGB8888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- pixel = *src;
- R = (Uint8)(pixel >> 24); G = (Uint8)(pixel >> 16); B = (Uint8)(pixel >> 8); A = (Uint8)pixel;
- pixel = (A << 24) | (R << 16) | (G << 8) | B;
- *dst = pixel;
+ pixel = *src;
+ pixel = (pixel >> 8) | (pixel << 24);
+ *dst = pixel;
posx += incx;
@@ -4949,3 +4942,2 @@ static void SDL_Blit_ABGR8888_BGR888_Scale(SDL_BlitInfo *info)
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
@@ -4968,6 +4960,5 @@ static void SDL_Blit_ABGR8888_BGR888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- pixel = *src;
- B = (Uint8)(pixel >> 16); G = (Uint8)(pixel >> 8); R = (Uint8)pixel;
- pixel = (B << 16) | (G << 8) | R;
- *dst = pixel;
+ pixel = *src;
+ pixel &= 0xFFFFFF;
+ *dst = pixel;
posx += incx;
@@ -6117,3 +6108,2 @@ static void SDL_Blit_BGRA8888_BGR888_Scale(SDL_BlitInfo *info)
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
@@ -6136,6 +6126,5 @@ static void SDL_Blit_BGRA8888_BGR888_Scale(SDL_BlitInfo *info)
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
- pixel = *src;
- B = (Uint8)(pixel >> 24); G = (Uint8)(pixel >> 16); R = (Uint8)(pixel >> 8);
- pixel = (B << 16) | (G << 8) | R;
- *dst = pixel;
+ pixel = *src;
+ pixel >>= 8;
+ *dst = pixel;
posx += incx;Build gives one warning, wonder if can be fixed... |
|
OK, I now see no warnings and get a clean diff of the generated The result would use another pair of eyes: @1bsyl, @slouken, @icculus ? diff --git a/src/video/SDL_blit_auto.c b/src/video/SDL_blit_auto.c
index 359c1bd..f64511f 100644
--- a/src/video/SDL_blit_auto.c
+++ b/src/video/SDL_blit_auto.c
@@ -756,7 +756,6 @@ static void SDL_Blit_RGB888_ARGB8888_Scale(SDL_BlitInfo *info)
{
Uint32 pixel;
const Uint32 A = 0xFF;
- Uint32 R, G, B;
int srcy, srcx;
Uint32 posy, posx;
int incy, incx;
@@ -776,8 +775,7 @@ static void SDL_Blit_RGB888_ARGB8888_Scale(SDL_BlitInfo *info)
srcx = posx >> 16;
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
pixel = *src;
- R = (Uint8)(pixel >> 16); G = (Uint8)(pixel >> 8); B = (Uint8)pixel;
- pixel = (A << 24) | (R << 16) | (G << 8) | B;
+ pixel |= (A << 24);
*dst = pixel;
posx += incx;
++dst;
@@ -2232,7 +2230,6 @@ static void SDL_Blit_BGR888_ARGB8888_Modulate_Blend_Scale(SDL_BlitInfo *info)
static void SDL_Blit_ARGB8888_RGB888_Scale(SDL_BlitInfo *info)
{
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
Uint32 posy, posx;
int incy, incx;
@@ -2252,8 +2249,7 @@ static void SDL_Blit_ARGB8888_RGB888_Scale(SDL_BlitInfo *info)
srcx = posx >> 16;
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
pixel = *src;
- R = (Uint8)(pixel >> 16); G = (Uint8)(pixel >> 8); B = (Uint8)pixel;
- pixel = (R << 16) | (G << 8) | B;
+ pixel &= 0xFFFFFF;
*dst = pixel;
posx += incx;
++dst;
@@ -3395,7 +3391,6 @@ static void SDL_Blit_ARGB8888_ARGB8888_Modulate_Blend_Scale(SDL_BlitInfo *info)
static void SDL_Blit_RGBA8888_RGB888_Scale(SDL_BlitInfo *info)
{
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
Uint32 posy, posx;
int incy, incx;
@@ -3415,8 +3410,7 @@ static void SDL_Blit_RGBA8888_RGB888_Scale(SDL_BlitInfo *info)
srcx = posx >> 16;
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
pixel = *src;
- R = (Uint8)(pixel >> 24); G = (Uint8)(pixel >> 16); B = (Uint8)(pixel >> 8);
- pixel = (R << 16) | (G << 8) | B;
+ pixel >>= 8;
*dst = pixel;
posx += incx;
++dst;
@@ -4163,7 +4157,6 @@ static void SDL_Blit_RGBA8888_BGR888_Modulate_Blend_Scale(SDL_BlitInfo *info)
static void SDL_Blit_RGBA8888_ARGB8888_Scale(SDL_BlitInfo *info)
{
Uint32 pixel;
- Uint32 R, G, B, A;
int srcy, srcx;
Uint32 posy, posx;
int incy, incx;
@@ -4183,8 +4176,7 @@ static void SDL_Blit_RGBA8888_ARGB8888_Scale(SDL_BlitInfo *info)
srcx = posx >> 16;
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
pixel = *src;
- R = (Uint8)(pixel >> 24); G = (Uint8)(pixel >> 16); B = (Uint8)(pixel >> 8); A = (Uint8)pixel;
- pixel = (A << 24) | (R << 16) | (G << 8) | B;
+ pixel = (pixel >> 8) | (pixel << 24);
*dst = pixel;
posx += incx;
++dst;
@@ -4947,7 +4939,6 @@ static void SDL_Blit_ABGR8888_RGB888_Modulate_Blend_Scale(SDL_BlitInfo *info)
static void SDL_Blit_ABGR8888_BGR888_Scale(SDL_BlitInfo *info)
{
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
Uint32 posy, posx;
int incy, incx;
@@ -4967,8 +4958,7 @@ static void SDL_Blit_ABGR8888_BGR888_Scale(SDL_BlitInfo *info)
srcx = posx >> 16;
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
pixel = *src;
- B = (Uint8)(pixel >> 16); G = (Uint8)(pixel >> 8); R = (Uint8)pixel;
- pixel = (B << 16) | (G << 8) | R;
+ pixel &= 0xFFFFFF;
*dst = pixel;
posx += incx;
++dst;
@@ -6115,7 +6105,6 @@ static void SDL_Blit_BGRA8888_RGB888_Modulate_Blend_Scale(SDL_BlitInfo *info)
static void SDL_Blit_BGRA8888_BGR888_Scale(SDL_BlitInfo *info)
{
Uint32 pixel;
- Uint32 R, G, B;
int srcy, srcx;
Uint32 posy, posx;
int incy, incx;
@@ -6135,8 +6124,7 @@ static void SDL_Blit_BGRA8888_BGR888_Scale(SDL_BlitInfo *info)
srcx = posx >> 16;
src = (Uint32 *)(info->src + (srcy * info->src_pitch) + (srcx * 4));
pixel = *src;
- B = (Uint8)(pixel >> 24); G = (Uint8)(pixel >> 16); R = (Uint8)(pixel >> 8);
- pixel = (B << 16) | (G << 8) | R;
+ pixel >>= 8;
*dst = pixel;
posx += incx;
++dst; |
|
These look good to me. |
OK, I took the liberty of squashing the perl script commits and regenerated SDL_blit_auto.c. |
|
I've tried to adapt a test case: I also tried to set some traces in the function. but curiosly one 1 show up (RGB_ARGB_Scale) |
|
Wait for you to investigate more? |
|
@sezero the test goes into the 6 functions and outputs CRC are the same ! |
|
So, the PR is good to go? |
|
for me, it seems ok also! |
|
OK, let's get this in. |
capehill
added a commit
to AmigaPorts/SDL
that referenced
this pull request
Jan 20, 2023
* Add a hint for D3D9Ex to avoid having to choose at compile-time * Use MSVC _byteswap intrinsics for SDL byteswapping functions This generates bswap on x86/x64 and rev on ARM * Fixed bug 5440 - MacCatalyst build failures C.W. Betts I tested building commit http://hg.libsdl.org/SDL/rev/55cdb379e866 on Mac Catalyst and found some issues: * MTLFeatureSet_iOS_* enums aren't available under Mac Catalyst. * OpenGL ES is unavailable under Mac Catalyst. * Some Metal features are available under Catalyst but not iOS, such as displaySyncEnabled. * Set Metal as the default renderer on Mac Catalyst Attaching a patch that will make SDL2 build for Mac Catalyst. * Use specific acquire and release variants of InterlockedExchange on ARM _InterlockedExchange_rel() is required for correctness on ARM because the _ReadWriteBarrier() macro is only a compiler memory barrier, not a hardware memory barrier. Due to ARM's relaxed memory model, this means the '*lock = 0' write may be observed before the operations inside the lock, causing possible corruption of data protected by the lock. _InterlockedExchange_acq() is more efficient on ARM because it avoids an expensive full memory barrier that _InterlockedExchange() does. * Implement SDL_MostSignificantBitIndex32 using MSVC intrinsics * consistently use TEXT() macro with LoadLibrary() and GetModuleHandle() cf. bug libsdl-org#5435. * SDL_wasapi_win32.c (WASAPI_PlatformThreadInit): use L instead of TEXT() because AvSetMmThreadCharacteristicsW specifically accepts WCHAR* input cf. bug libsdl-org#5435. * SDL_dinputjoystick.c (IsXInputDevice): adjust to be ANSI/UNICODE-agnostic cf. bug libsdl-org#5435. * RAWINPUT_InitWindowsGamingInput: change pNamespace from LPTSTR to PCWSTR because WindowsCreateStringReference specifically accepts const WCHAR * - WGI_JoystickInit(): ditto. cf. bug libsdl-org#5435. * SDL_windowswindow.c (SDL_HelperWindowCreate): adjust for ANSI/UNICODE: change SDL_HelperWindowClassName and SDL_HelperWindowName from WCHAR * to be const TCHAR* cf. bug libsdl-org#5435. * SDL_windowsjoystick.c (SDL_CreateDeviceNotification): use L, not TEXT() cf. bug libsdl-org#5435. * simplify Watcom implementation of SDL_MostSignificantBitIndex32() * move SDL_tcsstr definition to core/windows/SDL_windows.h * make ANSI/UNICODE versions of WIN??UTF8 macros individually available. * use WIN_StringToUTF8W macro instead of WIN_StringToUTF8, where needed: i.e. where the string is known guaranteed to be WCHAR*, in: - SDL_dinputjoystick.c (WIN_IsXInputDevice): VARIANT->var is BSTR (WCHAR*) - SDL_rawinputjoystick.c (RAWINPUT_AddDevice): string is WCHAR* - SDL_windows_gaming_input.c (IEventHandler_CRawGameControllerVtbl_InvokeAdded): string is WCHAR* There should be more of these.. * SDL_windows_main.c: use new WIN_StringToUTF8W macro * Valve contributed code is under the Zlib license * Allow setting the player index to -1, which turns off the player LED for PS5 controllers * Fixed detection of the Wooting Two keyboard, which shows up as an Xbox 360 controller * Add SDL_UpdateNVTexture() to update NV12/21 Texture (bug libsdl-org#5430) for renderer software, opengl, and opengles2 * Fixed invalid read in yuv_rgb_sse() (see bug libsdl-org#5430) * Add SDL_UpdateNVTexture for d3d11 (bug libsdl-org#5430) (not tested) * Fix compilation (implicit declaration of function) (see bug libsdl-org#5430) * Fix compilation on Window10 (see bug libsdl-org#5430) * Add SDL_UpdateNVTexture for META (bug libsdl-org#5430) (not tested) * Fix unused variable warning on METAL (see bug libsdl-org#5430) * wmmsg.h: constified wmtab * ran gendynapi.pl after SDL_UpdateNVTexture addition * use WIN_StringToUTF8W instead of WIN_StringToUTF8 where needed (#2) cf. bug libsdl-org#5435. - SDL_wasapi_win32.c (GetWasapiDeviceName): pwszVal is WCHAR* - windows/SDL_sysfilesystem.c (SDL_GetBasePath, SDL_GetPrefPath) - windows/SDL_sysurl.c (SDL_SYS_OpenURL): wurl is WCHAR* - SDL_windowssensor.c (ConnectSensor): bstr_name is WCHAR* - windows/SDL_systhread.c (SDL_SYS_SetupThread): strw is WCHAR* * video/windows: ANSI/UNICODE updates (cf. bug 5435): - explicitly use UNICODE versions of DrawText, EnumDisplaySettings, EnumDisplayDevices, and CreateDC: the underlying structures have WCHAR strings. - change WIN_UpdateDisplayMode and WIN_GetDisplayMode() to accept LPCWSTR instead of LPCTSTR for the same reason. - change WIN_StringToUTF8 and WIN_UTF8ToString to the explicit 'W' versions where appropriate. * Update config.guess and config.sub from mainstream. Recognizes riscv32be and riscv64be. * Add more SDL_HAVE_YUV defines * Fix D3D11 UpdateNVTexture (bug libsdl-org#5430) * Fix software UpdateNVTexture non fullscreen (bug libsdl-org#5430) * Fix D3D11 UpdateTextureNV in non fullscreen (bug libsdl-org#5430) * [KMS/DRM] Rewrite KMSDRM_LEGACY backend to accomodate Vulkan compatibility. Fix several bugs on that backend. * fix build after commit 26e76e851774 * [KMS/DRM] Add Vulkan suport to the KMSDRM_LEGACY backend.Minor text spacing tweaks for better readability. Comment out unused function. * [KMS/DRM] Add the missing files for Vulkan support to the KMSDRM_LEGACY backend, had forgotted to do -hg add-. * [KMS/DRM] Correct drmModeSetCursor() dimensions. * update config.guess and config.sub from mainstream. * [KMS/DRM] Don't use primary plane for scaling because that's unsupported on most LEGACY-only HW. * Fixed building when SDL_LIBUSB_DYNAMIC is defined * Fixed bug 5449 - SDL_DROPFILE update mouse location of drop in Cocoa Dominik Reichardt Exult (http://exult.info) has an editor app that uses GTK+2. Up to now we were using X's drag'n'drop to allow dropping of assets from the editor onto Exult. There is now an experimental branch that makes use of SDL_DROPFILE. That works under X, dropping in Exult's SDL2 window puts the asset right at the spot you dropped at. On macOS with native Exult and Quartz GTK+2 this doesn't work, the location of the drop is where the mouse was last tracked before you left the window (usually one of the edges, unless you tabbed out). All we tried out pointed to the fact that the location update needs to be done by the dropfile event in SDL2, not by our own (which always only worked after the Exult window getting focus). This patch adds this to SDL_cocoawindow.m and it works perfectly, passing the correct coordinates to our code (SDL_GetMouseState()). * Use Clang/GCC builtins for SDL byteswapping functions __builtin_bswap32/64 were introduced in GCC 4.3. __builtin_bswap16 was not available on x86 until GCC 4.8 due to a bug. __builtin_bswap32/64 were introduced in Clang 2.6. __builtin_bswap16 was introduced in Clang 3.2. * Disabled Bluetooth if BLE is not supported BluetoothManager is supported for Android API 18+. On older versions, skip Bluetooth instead of crashing. * [KMS/DRM] Prevent creating another default cursor everytime a window is created. Other fixes and cleanups. * [KMS/DRM] Fix cpmpilation warnings. Thanks to Ozkan Sezer for pointing this out! * [KMS/DRM] Small readability changes. * Fixed joysticks generating SDL mouse events * [KMS/DRM] Go back to the LEGACY interface only because using planes breaks compatibility with HW, so no advantage on using ATOMIC. * Fixed Xbox One Series X share button incorrectly triggering on newer firmware * Fixed bug 5080 - SDL_netbsdaudio: Always use the device's preferred frequency Nia Alarie The NetBSD kernel's audio resampling code is much simpler and lower quality than libsamplerate. Presumably, if SDL always performs I/O on the audio device in its native frequency, we can avoid resampling audio in the kernel and let SDL do it with libsamplerate instead. * regenerated configure * fixed permissions of xcode project file * KMSDRM_LEGACY is no longer legacy * [KMS/DRM] Fix vkQuake3 in OpenGL mode. * acinclude/libtool.m4: Apply macos11 patch from libtool bug #44605 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44605 https://github.com/macports/macports-ports/blob/master/devel/libtool/files/dynamic_lookup-11.patch ( Also see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44684 ) This also implicitly covers the macos10.10+ support patch from libtool mainstream which has been in since libtool-v2.4.3, i.e.: http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commit;h=e145288b059e14ab7e58fc6a304e82d9dad282a6 * [KMS/DRM] Cleanup remainings from plane/scaling usage. * SDL_UpdateNVTexture: for D3D11, same notation as SDL_UpdateTexture (bug libsdl-org#5430) * Fixed bug 5465 - Invalid memcpy inside SDL_GestureDelTouch (Thanks dmikushin and Yuki Okumura) * SDL_UpdateNVTexture: fixed pitch/bpp for GLES2 (bug libsdl-org#5430) * [KMS/DRM] Fix fullscreen to windowed transition. Fix aspect ratio correction without using planes. * [KMS/DRM] Move surface size info to window driverdata, for coherency. * [KMS/DRM] Unused code cleaning. * Gyro and Accel sensor support for Switch Pro Controller. Note that axes are changed to match the axes we're using with PlayStation controllers, since users will appreciate consistent behaviour across devices. * [KMS/DRM] Don't ask SDL to scale image when in Vulkan mode. * [KMS/DRM] Refactor KMSDR_CreateSurface to group all non-Vulkan stuff in a block. * opengl: More work on making line drawing match software renderer. * [KMS/DRM] Add warning comentary to avoid future experiments with scaling. * [KMS/DRM] Enable async pageflips. * testgamecontroller: log which controller the event came from * Only select the gamepad interfaces on the Xbox 360 wireless adapter * Don't blink the Xbox 360 LED when setting the player slot, it's probably already been set by a driver * [KMS/DRM] Refactor, improve and re-comment async pageflips code. * [KMS/DRM] Remove unused header. * [KMS/DRM] Adjust come return values. Improve comments. * Fixed bug 5461 - Add rewritten WSCONS driver for OpenBSD wahil1976 This patch adds a written-from-scratch WSCONS driver for OpenBSD. It does not have hardcoded keymaps, and it features mouse support when wsmux is available. For this to work, it needs access to the /dev/wskbd* devices which are not available to non-root users by default. Access to those can be granted by changing /etc/fbtab to give the logging user the ownership of those devices. * Fixed bug 5462 - debug trap update/fix of assembly for Apple devices David Carlier updating preprocessor constant and proposing 32 bits variant. * Fixed bug 5451 - Can't create EGLSurface in Wayland from SDLWindow (no EGLNativeWindow pointer) sashikknox In some cases, need create EGLWindow with SDLWindow. In X11 i can get pointer to NativeWindow from **struct SDL_SysWMinfo wmInfo** ```C++ struct SDL_SysWMinfo wmInfo; SDL_GetWindowWMInfo(ptSDLWindow, &wmInfo) #if defined(__unix__) && defined(SDL_VIDEO_DRIVER_X11) nativeWindow=(EGLNativeWindowType)wmInfo.info.x11.window; nativeDisplay=(EGLNativeDisplayType)wmInfo.info.x11.display; #endif ``` than i can create EGLSurface ``` eglCreateWindowSurface(nativeDisplay, EGL_CONFIG, nativeWindow, SURFACE_ATTRIBUTES); ``` in Wayland i can do it with same way, just need pointer to **EGLWindow**, we already have pointer to **wl_display** from **SDL_sysWMInfo**, need add to **wl** struct in SDL_SysWMInfo another pointer to **struct wl_egl_window *egl_window;**. And in wayland backend, in function **Wayland_GetWindowWMInfo** return pointer to **egl_window** from **SDL_WindowData** Now i use patched statically built SDL2 in port of Quake 2 GLES2 for SailfishOS (it use QtWayland): link to SDL2 commit and changed string for patch: - savegame/sailfish-quake2@6858a61 - https://github.com/savegame/lp-public/blob/b1e29e87b9d15780e47f04918b329ac15554fc69/SDL2/src/video/wayland/SDL_waylandwindow.c#L463 link to use in Quake2 port: 1. here i get pointer to EGLNativeWindowType: https://github.com/savegame/lp-public/blob/6d94fedb1b720da24999ae6286a1809cd3d55ff5/Engine/Sources/Compatibility/OpenGLES/EGLWrapper.c#L319 2. then use it for create EGLSurface: https://github.com/savegame/lp-public/blob/6d94fedb1b720da24999ae6286a1809cd3d55ff5/Engine/Sources/Compatibility/OpenGLES/EGLWrapper.c#L391 * Fixed bug 5463 - generated Wayland interfaces are included in the library's ABI Simon McVittie In versions since 1.15, the `code` mode is a deprecated alias for `public-code`, which emits symbols with default visibility, overriding SDL's -fvisibility=hidden option. Use the `private-code` mode instead. This emits symbols with hidden visibility, so they do not affect the ABI of libSDL. See also: https://bugreports.qt.io/browse/QTBUG-73099, https://lists.freedesktop.org/archives/wayland-devel/2018-February/037097.html * Fixed bug 5287 - Support building for UWP with CMake Jan Niklas Hasse Actually the SDL2-static target works, if I set SDL_SENSOR to OFF. Awesome! See this patch: https://github.com/microsoft/vcpkg/blob/master/ports/sdl2/0003-sdl2-fix-uwp-build.patch * Fixed bug 5195 - Replugging in “mixed” controller types crashes on macOS RustyM This is related to Bug 5034, but crashes under a somewhat different condition. In the latest tip (changeset 13914) or with the SDL 2.0.12 source + David’s 5034 patch, unplugging and then replugging in certain controller types on macOS will crash. A mix of new controllers like Switch Pro, PS4 and Xbox One all work without issue. But if a controller without a rumble function, like many SNES retro USB gamepads, is mixed with a PS4 or Switch Pro controller it will crash. File: joystick/darwin/SDL_sysjoystick.c Function: static recDevice *FreeDevice(recDevice *removeDevice) On line 159: while (device->pNext != removeDevice) { Causes: Thread 1: EXC_BAD_ACCESS (code=1, address=0x188) This can be reproduced in testgamecontroller" by starting the test program with both a “retro” controller plugged in and a “modern rumble” controller (Switch Pro/PS4). This may crash on launch, but it depends on which controller ends up as device 0. If it doesn’t crash, unplug the “modern rumble” controller and plug it back in. Some of the "retro" controllers I’ve seen this crash with: - iBuffalo SNES Controller - 8Bitdo SN30 Gamepad (in MacOS mode) - Retrolink NES Controller - HuiJia SNES Controller Adaptor The issue appears macOS specific. Seen on 10.12.6 and 10.14.6. Not seen on Windows 10. The while loop in FreeDevice() assumes that every device is not NULL. recDevice *device = gpDeviceList; while (device->pNext != removeDevice) { device = device->pNext; } device->pNext = pDeviceNext; So maybe we should check for NULL here? Or instead prevent adding NULL devices to the list in the first place? Checking device for NULL before entering the loop appears to work. recDevice *device = gpDeviceList; if (!device) { while (device->pNext != removeDevice) { device = device->pNext; } } device->pNext = pDeviceNext; * Fixed bug 5445 - Incorrect Switch Pro Controller face buttons when SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS disabled jibb I'm testing with DualShock 4, DualSense, Switch Pro Controller, and PowerA Switch Controller. I'm using the standard mapping file from here: https://raw.github.com/gabomdq/SDL_GameControllerDB/master/gamecontrollerdb.txt With SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS turned off (set to "0") I expect the button positions to be the same on all devices, based on Xbox controller button naming (eg SDL_GameControllerGetButton(g, SDL_CONTROLLER_BUTTON_Y) gives me whether the North face button is pressed). However, the Switch Pro Controller layout is wrong (matching labels rather than positions, so X and Y are swapped and A and B are swapped). And with the PowerA controller the East and West buttons are correct, but the North and South buttons are swapped instead. Mathias Kaerlev Also seeing this on 2.0.14. This is most likely a regression, since we weren't seeing this on an earlier SDL version. I suspect it might be caused by this commit: spurious/SDL-mirror@a569b21#diff-da9344d94c66b8c702a45e7649f412039f08bba83bd82de33f5c80ea9c8c39d5 It seems like both the HIDAPI driver and SDL_gamecontroller.c will try to swap the buttons if the hint is set to 0, causing the button remap to cancel out. * Make sure the HIDAPI device is locked when closing it, in case there is rumble pending that didn't complete * Always lock the HIDAPI device when closing, in case rumble is pending * Added HIDAPI rumble debug info * Fixed rumble reset failing for Switch Pro controllers in USB mode * Phantom Nintendo Switch Pro Controller initialization problem * Get the serial number for the Nintendo Switch Pro controller * Fixed build * SDL_hidapi_switch.c: fix build with older compilers * [KMS/DRM] Small fix to KMSDRM_Waitpageflip(). More comments on how it works. * Fixed the screenshot button mapping on third party Bluetooth Nintendo Switch Pro controllers * fix build with --disable-directx * Fixed bug 5473 - Add WSCONS support for NetBSD wahil1976 This patch adds WSCONS support for NetBSD. * [KMS/DRM] Fix for bug libsdl-org#5470: ratio correction for fullscreen windows with no matching resolution. Correct bracket position in else statements so they follow the coding style. * [KMS/DRM] Fix for bug libsdl-org#5468: corruption on dynamic cursor changing caused by wrong buffer size. * Add basic testgles2_sdf program to demonstrate sign distance field with opengles2 * Fix declarations after statement * fix AC_CHECK_HEADER for libusb.h * hidapi/libusb/hid.c: whitespace tidy-up. * SDL_virtualjoystick.c: remove wrong #endif comment. * [KMS/DRM] Revert unaproved fix for bug libsdl-org#5465. * hidapi/libusb/hid.c: fix race condition on device close (bug libsdl-org#5484) From hidapi mainstream git: libusb/hidapi#142 libusb/hidapi@d2c3a98 Read callback may fire itself on its own even after its been requested to stop and exactly before the calling code waits for its completion in indefinite loop. Explicitly preventing re-fireing the submission loop fixes the issue. * Use PS4 rumble hint as the default for the PS5 rumble hint Existing SDL applications may not know about the need to set a specific hint to enable rumble on PS5 controllers, even though they may already set the equivalent SDL_HINT_JOYSTICK_HIDAPI_PS4_RUMBLE hint for PS4 controller rumble support. Rather than requiring those developers update their apps, let's use the SDL_HINT_JOYSTICK_HIDAPI_PS4_RUMBLE value as an indication of the behavior they are expected for all PlayStation controllers. * Implement keyboard grab support for Wayland Use zwp_keyboard_shortcuts_inhibit_manager_v1 to allow SDL applications to capture system keyboard shortcuts like Alt+Tab when keyboard grab is enabled via SDL_HINT_GRAB_KEYBOARD. * Don't add paddle mappings for the Xbox One Elite Series 1 controller, since they can't be unmapped and read directly on that controller. * Hint SDL_HINT_JOYSTICK_HIDAPI_JOY_CONS added so we can recognise a Joy-Con as half a Pro Controller, so we can read its analog input and read its sensors just like we do a Pro Controller. * renamed my_gradd.h to SDL_gradd.h * Implement support for minimizing windows on Wayland This required a bit of extra code to deal with the transition from minimized back to fullscreen * Fixed initializing the Nyko and EVORETRO GameCube adaptors This requires root on most Linux distributions, as we have to directly send USB messages to the devices to enable input reports. * Make sure we only do GameCube adapter initialization if we were able to load libusb * Improve reliability of cursor hiding on GNOME Wayland Hiding the cursor doesn't appear to work reliably on GNOME when another window steals mouse focus right as we call SDL_ShowCursor(SDL_DISABLE). This can happen when the keyboard shortcut inhibition permission prompt appears in response to a call to SDL_SetRelativeMouseMode() with SDL_HINT_GRAB_KEYBOARD=1. The result is that the default cursor is stuck locked in position and visible on screen indefinitely. By redrawing the cursor on pointer focus enter, the cursor now disappears upon the first mouse motion event. It's not perfect but it's way better than the current behavior. * Fixed build on Android and iOS * Fixed build * hidapi.h: adjust so that it gives a smaller diff against mainstream * old os2 analogue joystick code ported from SDL-1.2. disabled by default, build-tested only. * SDL_dinputjoystick.c: fixes to dfDIJoystick2[] array from Wine git. Fix V/A/FSlider dwOfs values in c_dfDIJoystick2 https://source.winehq.org/git/wine.git/commitdiff/af2f4194263702a946c65d255580176ee50b5914 Add missing ASPECT flags for c_dfDIJoystick2 https://source.winehq.org/git/wine.git/commitdiff/e2e100272ffede3c720da7bbd11b53ac0bcee8eb Closes bug libsdl-org#5474. * ControllerList: fix typo * Added support for the EVORETRO GameCube Adapter in PC mode * fix permissions of config.guess and config.sub * minor autotools build system updates. * Implement support for inhibiting the screensaver on Wayland We support both the org.freedesktop.ScreenSaver D-Bus API (same as the X11 backend) and the Wayland idle_inhibit_unstable_v1 protocol. Some Wayland compositors only support one or the other, so we need both to for broad compatibility. * Fix continuous scrolling speed on Wayland Wayland compositors seem to have standardized on 10 units per "wheel tick" for continuous scroll events, so we need to convert these axis values to ticks by dividing by 10 before reporting them in SDL_MOUSEWHEEL events. * added SDL_JOYSTICK_OS2 to SDL_config.h.in and SDL_config.h.cmake * renamed SDL_JOYSTICK_USBHID_MACHINE_JOYSTICK_H to SDL_HAVE_MACHINE_JOYSTICK_H * os2audio: changed backend name from MMOS2 to DART (like SDL-1.2) * move outdated winmm and psp joystick codes to struct _SDL_JoystickDriver build-tested only. (bug libsdl-org#5472.) * Implement keyboard grab support for Windows This is implemented via a low-level keyboard hook. Unfortunately, this is rather invasive, but it's how Microsoft recommends that it be done [0]. We want to do as little as possible in the hook, so we only intercept a few crucial modifier keys there, while leaving other keys to the normal event processing flow. We will only install this hook if SDL_HINT_GRAB_KEYBOARD=1, which is not the default. This will reduce any compatibility concerns to just the SDL applications that explicitly ask for this behavior. We also remove the hook when the grab is terminated to ensure that we're not unnecessarily staying involved in key event processing when it's not required anymore. [0]: https://docs.microsoft.com/en-us/windows/win32/dxtecharts/disabling-shortcut-keys-in-games * Fixed bug 5467 - SDL sys timer Mac OS update proposal David Carlier Change of api from 2016 which reduce code complexity a bit. * Fixed bug 5466 - Add haptic support for Stadia Controller Dimitriy Ryazantcev Consider adding support for Stadia Controller haptics. Here is example code how to deal with it: https://github.com/chromium/chromium/blob/99314be8152e688bafbbf9a615536bdbb289ea87/device/gamepad/hid_haptic_gamepad.cc#L45 * Minor cleanup * waylandtouch: Don't export interface structs These are explicitly written in C code rather than generated at build time, so they weren't affected by changing how we invoke wayland-scanner. Signed-off-by: Simon McVittie <smcv@collabora.com> * Added Stadia controller source file to Visual Studio and Xcode projects * Implement Wayland_SetWindowResizable * [KMS/DRM] Bugfix for libsdl-org#5489: Non-FULLSCREEN windows incorrecty use videomode changing to look fullscreen. * fix build failure due to -Werror=declaration-after-statement (bug libsdl-org#5500) * minor clean-up in SDL_os2audio.c * CMakeLists.txt: fix check_symbol_exists() for clock_gettime_nsec_np * better check for clock_gettime_nsec_np() -- cf. bug libsdl-org#5467. * GLES2 SDL_Renderer: remove old ZUNE_HD defines and simplify shader cache * Refactor keyboard grab to be managed by the video core This gives us flexibility to add others hints to control keyboard grab behavior without having to touch all of the backends. It also allows us to possibly expose keyboard grab separately from mouse grab for applications that want to manage those independently. * Fix grabbing Alt+Tab and Alt+Esc on Windows 7 * wayland: cancel key repeat when keyboard focus is lost SDL_SetKeyboardFocus(NULL) will lift any keys still pressed when keyboard focus leaves the window, but then key repeat comes behind our backs and presses the key down again. This results in an infinite stream of SDL_KEYDOWN events when focus leaves the window with a key down (particularly noticeable with Alt+Tab). * Rename SetWindowGrab() to SetWindowMouseGrab() * Removed non-functional window grab implementations * Fixed bug 5493 - Hint to let the user opt out of having Switch controllers' Home button lit when opened jibb New hint to let the user opt out of having Switch controllers' Home button lit when opened. This is more consistent with the Switch itself (which doesn't light the button normally) and may be preferred by users who may disconnect their controller without letting the application close it. I think this warrants a Switch-specific hint because the default behaviour is unusual (inconsistent with using a Switch controller on a Switch itself or with some other programs on PC), and because of that it's distinct from other lights (the player number on Switch controllers and the player colour on PlayStation controllers). * Fixed bug 5481 - iOS-specific main sources not used for CMake build. Aaron Barany The CMake build for SDL doesn't set SDLMAIN_SOURCES on iOS to the sources in src/main/ios. As a result, SDL fails to initialize since it falls back to the dummy main. Adding the line file(GLOB SDLMAIN_SOURCES ${SDL2_SOURCE_DIR}/src/main/uikit/*.c) fixes the issue. * Fixed bug 5497 - SDL_COMPOSE_ERROR is wrong UMU #define SDL_COMPOSE_ERROR(str) SDL_STRINGIFY_ARG(__FUNCTION__) ", " str I think SDL_STRINGIFY_ARG should be removed. #define SDL_COMPOSE_ERROR(str) __FUNCTION__ ", " str (verified with Visual Studio 2019) * DirectFB: Split input grab handling into keyboard and mouse parts The grabbed_window field is superfluous now since SDL added the SDL_GetGrabbedWindow() function, so it can be removed. DirectFB_SetWindowMouseGrab() is also simplified because SDL handles ungrabbing any previously grabbed window prior to calling SetWindowMouseGrab() now. Compile-tested only. * SDL_SoftStretch: re-enable USE_ASM_STRETCH path for gcc >= 4.6 * Expose separate keyboard and mouse grab support This adds SDL_SetWindowKeyboardGrab(), SDL_GetWindowKeyboardGrab(), SDL_SetWindowMouseGrab(), SDL_GetWindowMouseGrab(), and new SDL_WINDOW_KEYBOARD_GRABBED flag. It also updates the test harness to exercise this functionality and makes a minor fix to X11 that I missed in https://hg.libsdl.org/SDL/rev/02a2d609369b To fit in with this new support, SDL_WINDOW_INPUT_CAPTURE has been renamed to SDL_WINDOW_MOUSE_CAPTURE with the old name remaining as an alias for backwards compatibility with older code. * SDL_SoftStretch: disable asm path if mprotect isn't available (see bug libsdl-org#3816) * SDL_UpdateTexture: intersect update rect with texture dimension - fix crash with software renderer - fix non texture update with opengl/gles2 * SDL_Update{YUV,NV}Texture: also intersect rect with texture dimension * Fixed building with mingw64 * Fixed bug 3816 - asm code in video/SDL_stretch.c Ozkan Sezer - adds MSVC __declspec(align(x)) support, - disables asm if PAGE_ALIGNED no macro is defined, - still disables asm for gcc < 4.6, need more info, - drops Watcom support. * The Sharkoon Skiller SGH2 headset hangs in DirectInput enumeration, so avoid it here just in case. See bug 5485 for details. * Fixed compile warning * Added explicit case from Uint8 to int before subtracting offset * Fixed bug 3816 - asm code in video/SDL_stretch.c Sylvain I propose this new version for SDL_stretch.c that drops mprotect and asm Code is similar to the StretchLinear, but the steps computation are kept similar to the nearest. so that: - it's pixel perfect with nearest - as fast as asm I think - no asm, nor mprotect - benefit for all archicture * SDL_LowerSoftStretchLinear: assign result from scale_mat() to ret. otherwise it would always return -1 when SSE and NEON instrinsics are absent. * X11: Ungrab the keyboard when the mouse leaves the window GNOME Mutter requires keyboard grab for certain important functionality like window resizing, interaction with the application context menu, and opening the Activites view. To allow Mutter to grab the keyboard as needed, we'll ungrab when the mouse leaves our window. To be safe, we'll do this for all WMs since forks of Mutter and Matacity (and possibly others) may have the same behavior, and we don't want to have to keep track of those. * Added WIN_IsWindows8OrGreater() for internal use * Fixed PS4 controllers over Bluetooth on Windows 7 * Fixed build warning * Fixed compiler warnings * SDL_stretch: remove un-used vars, same notation as blit functions * Fixed bug 5510 - simplify the scaling functions * Fixed bug 5510 - simplify the scaling functions blit auto (generated file) * config.guess and config.sub updates from mainstream * SDL_config_os2.h: remove some duplicated lines. * Note that the Logitech G29 (PS4) is a racing wheel * Make sure we don't create a game controller mapping for HID devices that aren't supported by HIDAPI * Add checks for maximun scaling size (see bug libsdl-org#5510) * Remove old YUV fixme * Properly handle keys already down when the hook is installed For keys that are already down when we install the keyboard hook, we need to allow the WM_KEYUP/WM_SYSKEYUP message to be processed normally. This ensures that other applications see the key up, which prevents the key from being stuck down from the perspective of other apps when our grab is released. * [KMS/DRM] Patch for bug libsdl-org#5513. KMSDRM backend can now manage and use several displays. * [KMS/DRM] Remove unused KMSDRM_SetWindowGrab prototype in header file. * Remove checks on destination scaling size (see bug libsdl-org#5510) * added --enable-xinput switch for windows builds * Fixed crash if the GameCube controller hasn't been opened yet * [KMS/DRM] Correct small omission on bugfix libsdl-org#5513: y-coord correction has to be done on WarpMouseGlobal, too. * Revert checks on destination scaling size (see bug libsdl-org#5510) * Add default handler for Alt+Tab while keyboard grab is enabled By default, we will minimize the window when we receive Alt+Tab with a full-screen keyboard grabbed window to allow the user to escape the full-screen application. Some applications like remote desktop clients may want to handle Alt+Tab themselves, so provide an opt-out via SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED=0. * [KMS/DRM] Fix for bug libsdl-org#5518: only do async pageflips when hardware supports them. * [KMS/DRM] Merge patch for bug 5522#: Implement KMSDRM_GetWindowWMInfo(). * wayland: Fix transform and scale handling when setting display mode * cmake: enable AddressSanitizer in Debug builds * free the 'data_device_manager' * free 'outputs' in 'Wayland_DestroyWindow' * Don't enable address sanitize flags without checking compiler first * Fixed bug 5524 - Pass NSString to NSLog() Hiroyuki Iwatsuki If you pass the C string directly to NSLog(), it will be garbled with Japanese and probably other language strings, or no log will be output at all. NSLog("Hello, World!"); // => "Hello, World!" NSLog("こんにちは、世界！"); // => No output... Therefore, you need to convert the string to an NSString before passing it to NSLog(). NSString *str = [NSString stringWithUTF8String:"こんにちは、世界！"]; NSLog(@"%@", str); // => "こんにちは、世界！" Thank you. * wayland: Don't crash when the properties of already existing wl_output change * Don't uncorrelate while rumble is active and stay correlated longer in case raw input messages are lagging a bit. * cmake: enable AddressSanitizer in Debug builds if supported * Removed support for clock_gettime_nsec_np() SDL_GetTicks() was broken and it's not adding any real value here. * Added test command line options to force different window types * Fixed bug 5471 - Creating a fullscreen desktop window goes windowed temporarily This is caused by the Metal renderer recreating the window because by default we create an OpenGL window on macOS. It turns out that at least on macOS 10.15, a window that has been initialized for OpenGL can also be used with Metal. So we'll skip recreating the window in that case. * Fixed detecting the paddles on the Xbox Elite Series 1 controller * SDL_ConvertColorkeyToAlpha: remove and clarify a FIXME This function doesn't handle bpp 1 or 3 case, because those formats never have an alpha channel * SDL_vulkan_utils: minor code clean-up * KMSDRM doesn't have a window manager, so all windows are fullscreen * Android: documention update * Backed out changeset 1cde3dd0f44d - this breaks windows which are created and then set to FULLSCREEN_DESKTOP * Fixed compiler warning * Updated runtime dependency on libudev * Fix Xbox Series X controller on macOS There were two different implementations of IsBluetoothXboxOneController(), one in SDL_hidapi_xbox360.c and one in SDL_hidapi_xboxone.c. The latter had been updated to include USB_PRODUCT_XBOX_ONE_SERIES_X_BLUETOOTH while the former had not. This mismatch led to the Xbox Series X failing on macOS only. We have special code for handling the 360Controller driver for macOS which requires us to use the Xbox 360 driver for wired Xbox One controllers, and the SDL_hidapi_xbox360 version of IsBluetoothXboxOneController() was used to determine which devices were wired. In addition to adding the missing USB_PRODUCT_XBOX_ONE_SERIES_X_BLUETOOTH, this change moves IsBluetoothXboxOneController() into a single shared function which will ensure this bug won't happen again. * [KMS/DRM] Restore all-windows-are-fullscreen functionality, since there is no window manager in KMSDRM. * [KMS/DRM] Remove redundant SDL_SendWindowEvent() call. * [KMS/DRM] Merge patch for bug libsdl-org#5532: No need to correct cursor position now that all windows are fullscreen. Link: https://bugzilla.libsdl.org/show_bug.cgi?id=5519. * [KMS/DRM] Replace indent tabs with spaces, as intended. * [KMS/DRM] Fix build warning. * minor updates to libc function checks * SDL: fix packet handling for original version of Stadia FW * avoid some pedantic warnings in array initializers * add '-shared-libasan' to debug flags (bug libsdl-org#5533) * enable AddressSanitizer only for GCC 5 onwards (bug libsdl-org#5533) * make AddressSanitizer optional and disabled by default * [KMS/DRM] Bugfix number libsdl-org#5535: Improve reliability, by wahil1976. * free the 'display' after it was added to global list * Backed out changeset 852a7bdbdf4b This causes a use-after-free memory error * Fix waiting on condition variables with the SRW lock implmentation When SleepConditionVariableSRW() releases the SRW lock internally, it causes our SDL_mutex_srw state to become inconsistent. The lock is unowned yet inside, the owner is still the sleeping thread and more importantly the owner count is still 1. The next time someone acquires the lock, they will bump the owner count from 1 to 2. At that point, the lock is hosed. From the internal lock state, it looks to us like that owner has acquired the lock recursively, even though they have not. When they call SDL_UnlockMutex(), it will see the owner count > 0 and not call ReleaseSRWLockExclusive(). Now when someone calls SDL_CondSignal(), SleepConditionVariableSRW() will start the wakeup process by attempting to re-acquire the SRW lock. This will deadlock because the lock was never released after the other thread had used it. The thread waiting on the condition variable will never be able to wake up, even if the SDL_CondWaitTimeout() function is used and the timeout expires. * Fixed bug 5543 - Wayland: Fix waylandvideo.h warnings wahil1976 This patch fixes the warnings seen when compiling the Wayland backend. This will also be required in the future to avoid issues with compilation. * Fixed bug 5539 - Clang 11 fails to compile a CMake build with conflicting types for _m_prefetchw vladius In SDL_cpuinfo.h it seems like <intrin.h> is not included when __clang__ is defined, as the comment in the file explicitly reads: "Many of the intrinsics SDL uses are not implemented by clang with Visual Studio" However, the SDL_endian.h header does include <intrin.h> without any precautions like: >#ifdef _MSC_VER >#include <intrin.h> >#endif Maybe it should be changed to something like: >#ifdef _MSC_VER >#ifndef __clang__ >#include <intrin.h> >#endif >#endif * Report found joysticks to SDL for event generation (fixes testjoystick) * Update for 2.0.14 release * Do not loop forever * Update version string * Try to filter out invalid UTF-8 bytes when sending text events (libsdl-org#190) * Open screens with SA_LikeWorkbench. This should fix issue with requester palette * Use smart refresh mode also in fullscreen mode. This avoids potential cosmetic issues with open requesters * Give screen a title for identification purposes * Implement SDL_OpenURL * Adapt to SDL_VideoDevice struct changes * Wait for window resize to happen to avoid issue where consequtive SetWindowAttrs calls seem to fail in SDL_SetWindowSize + SDL_SetWindowPos combo * Work around GCC10 change that triggered linking failure with static library * Disable SA_Compositing in fullscreen mode for a small performance gain * Set global IExec and INewlib only if required * Cleanup * More cleanup * More cleanup * Cleanup * Patch OGLES2 renderer compilation for AmigaOS 4 Co-authored-by: Cameron Gutman <aicommander@gmail.com> Co-authored-by: Sam Lantinga <slouken@libsdl.org> Co-authored-by: Ozkan Sezer <sezeroz@gmail.com> Co-authored-by: Sylvain Becker <sylvain.becker@gmail.com> Co-authored-by: Manuel Alfayate Corchete <redwindwanderer@gmail.com> Co-authored-by: Jordan Christiansen <xordspar0@gmail.com> Co-authored-by: JibbSmart <none@none> Co-authored-by: Ryan C. Gordon <icculus@icculus.org> Co-authored-by: Cameron Gutman <cameron.gutman@gmail.com> Co-authored-by: Simon McVittie <smcv@collabora.com> Co-authored-by: Ethan Lee <flibitijibibo@flibitijibibo.com> Co-authored-by: Brandon DeRosier <x@bdero.me> Co-authored-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> Co-authored-by: Christian Rauch <Rauch.Christian@gmx.de> Co-authored-by: capehill <juha.niemimaki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my compiler does not seem to make these optimizations, so it is worth to help a bit...
The script was NOT tested!