oss-fuzz ASAN fixes #713
Merged
oss-fuzz ASAN fixes #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SF_CART_INFO_16K struct has an additional 4 byte field to hold the size of 'tag_text' which the file header doesn't, so don't include it as part of the check when looking for the max length. https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26026
'blockalign' is the size of a block, and each block contains 7 samples per channel as part of the preamble, so check against 'samplesperblock' rather than 'blockalign'. Also add an additional check that the block is big enough to hold the samples it claims to hold. https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26803
|
Thanks again @bobsayshilol ! |
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Sep 29, 2021
Source: https://github.com/libsndfile/libsndfile MR: 112098 Type: Security Fix Disposition: Backport from libsndfile/libsndfile#713 ChangeID: 10d137de063b7a1e543ee96fbcf948945a452869 Description: Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
seambot
pushed a commit
to seamapi/poky
that referenced
this pull request
Sep 29, 2021
Source: https://github.com/libsndfile/libsndfile MR: 112098 Type: Security Fix Disposition: Backport from libsndfile/libsndfile#713 ChangeID: 10d137de063b7a1e543ee96fbcf948945a452869 Description: (From OE-Core rev: f999bac187a935821f8580f3c5b1d08107ba9851) Signed-off-by: Armin Kuster <akuster@mvista.com> Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the security issues spotted by oss-fuzz in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26026 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=26803. Of the other publicly visible security issues only https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27503 looks frightening, and that looks like it'll go away once the UBSan issues in ALAC are fixed.