Skip to content

Conversation

@minad
Copy link
Member

@minad minad commented Apr 19, 2019

Fixes #208

@minad minad changed the title Travis/compiler versions Test against multiple specific clang/gcc versions Apr 19, 2019
* no changes to the library code
* conversion issues in the demo testsuite fixed
* add CONV_WARNINGS and enable the warnings only for clang-7 (for now)
* disable Wsystem-headers if Wconversion is enabled, to avoid warnings from the system headers
@minad
Copy link
Member Author

minad commented Apr 19, 2019

@sjaeckel I added the Wconversion warnings here - enabled only on recent clang-7 which does not give unneessary false positives.

Copy link
Contributor

@czurnieden czurnieden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More castings than in a trauma centre in Aspen/Colorado in high season but otherwise&hellip

@minad
Copy link
Member Author

minad commented Apr 24, 2019

More castings than in a trauma centre in Aspen/Colorado in high season but otherwise&hellip

But only in the tests suite :)

@sjaeckel sjaeckel merged commit a6b5da2 into libtom:develop Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pick a few compiler versions and test against them

3 participants