make mp_word private #267
Merged
make mp_word private #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minad
force-pushed
the
private_mp_word
branch
2 times, most recently
from
950963e to
bdd5228
Compare
Member
Author
|
@sjaeckel What do we have to check here? Do you see any downsides of this? |
nijtmans
approved these changes
May 20, 2019
Collaborator
nijtmans
left a comment
nijtmans
left a comment
There was a problem hiding this comment.
Yes, it makes sense to make mp_word private. There is a chance that user code uses it for their own internal purposes, I don't know any such examples (Tcl doesn't do this!). This PR makes mp_word deprecated, that rules out any real risk. I agree with this change!
I'll have to rebase #216, but I have to do that anyway. I will wait for this one to be merged first.
Thanks!
sjaeckel
approved these changes
May 21, 2019
mp_word is an internal type and it is problematic if it is exposed in the public api. See for example #216 - MSVC does not support 128 bit mp_words. But it is perfectly ok to use those internally in the library, as long as the library is compiled with GCC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mp_word is an internal type and it is problematic if it is exposed
in the public api. See for example #216 - MSVC does not support 128 bit
mp_words. But it is perfectly ok to use those internally in the library,
as long as the library is compiled with GCC.
Ping @nijtmans - does it make sense to hide the mp_word type from the public api in general?