Skip to content

do 2 MR rounds for numbers >=2048bits #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2019
Merged

do 2 MR rounds for numbers >=2048bits #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d46cb16
removed obsolete check
czurnieden May 19, 2019
1cbfbe0
do 2 MR rounds for numbers >=2048bits
sjaeckel May 18, 2019
51cda5b
use correct amount of MR trials in tests
sjaeckel May 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions bn_mp_prime_is_prime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ mp_err mp_prime_is_prime(const mp_int *a, int t, mp_bool *result)
/* default to no */
*result = MP_NO;

/* valid value of t? */
if (t > MP_PRIME_SIZE) {
return MP_VAL;
}

/* Some shortcuts */
/* N > 3 */
if (a->used == 1) {
Expand Down
5 changes: 2 additions & 3 deletions bn_mp_prime_rabin_miller_trials.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ static const struct {
{ 768, 5 },
{ 896, 4 },
{ 1024, 4 },
{ 2048, 2 },
{ 4096, 1 },
{ 2048, 2 } /* For bigger keysizes use always at least 2 Rounds */
};

/* returns # of RM trials required for a given bit size and max. error of 2^(-96)*/
Expand All @@ -35,7 +34,7 @@ int mp_prime_rabin_miller_trials(int size)
return (x == 0) ? sizes[0].t : sizes[x - 1].t;
}
}
return sizes[x-1].t + 1;
return sizes[x-1].t;
}


Expand Down
6 changes: 3 additions & 3 deletions demo/test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ static int test_mp_prime_is_prime(void)
mp_read_radix(&a,
"91xLNF3roobhzgTzoFIG6P13ZqhOVYSN60Fa7Cj2jVR1g0k89zdahO9/kAiRprpfO1VAp1aBHucLFV/qLKLFb+zonV7R2Vxp1K13ClwUXStpV0oxTNQVjwybmFb5NBEHImZ6V7P6+udRJuH8VbMEnS0H8/pSqQrg82OoQQ2fPpAk6G1hkjqoCv5s/Yr",
64);
mp_prime_is_prime(&a, 8, &cnt);
mp_prime_is_prime(&a, mp_prime_rabin_miller_trials(mp_count_bits(&a)), &cnt);
if (cnt == MP_YES) {
printf("Arnault's pseudoprime is not prime but mp_prime_is_prime says it is.\n");
goto LBL_ERR;
Expand All @@ -900,7 +900,7 @@ static int test_mp_prime_is_prime(void)
mp_set(&a, 1uL);
mp_mul_2d(&a,1119,&a);
mp_add_d(&a, 53uL, &a);
err = mp_prime_is_prime(&a, 8, &cnt);
err = mp_prime_is_prime(&a, mp_prime_rabin_miller_trials(mp_count_bits(&a)), &cnt);
/* small problem */
if (err != MP_OKAY) {
printf("\nfailed with error: %s\n", mp_error_to_string(err));
Expand Down Expand Up @@ -930,7 +930,7 @@ static int test_mp_prime_is_prime(void)
/* let's see if it's really a safe prime */
mp_sub_d(&a, 1uL, &b);
mp_div_2(&b, &b);
err = mp_prime_is_prime(&b, 8, &cnt);
err = mp_prime_is_prime(&b, mp_prime_rabin_miller_trials(mp_count_bits(&b)), &cnt);
/* small problem */
if (err != MP_OKAY) {
printf("\nfailed with error: %s\n", mp_error_to_string(err));
Expand Down