Import stddef in tommath.h #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Well, I don't think that's right: size_t is used in tommath.h, so - at least - whatever header file provides it should be included at the top of tommath.h somewhere. Second, the header providing size_t is <stddef.h>, so including that in tommath.h should be the 'correct' thing to do. IMHO. |
nomeata
force-pushed
the
stdlib
branch
2 times, most recently
from
b283ae1 to
ce25ee6
Compare
Contributor
Author
|
Ah, thanks for educating me about |
nomeata
changed the title
nijtmans
approved these changes
Jul 15, 2019
Collaborator
nijtmans
left a comment
nijtmans
left a comment
There was a problem hiding this comment.
Yes, this is the 'right' thing to do, IMHO. B.T.W.: I never noted this in libtommath, because I simply always add <stddef.h> first in my header files, but every header file should be self-contained, so it includes header-files which contain definitions it needs.
sjaeckel
changed the title
At least here (compiling for WebAssembly (`wasm32-unknown-unknown-wasm`), I need this, otherwise `size_t` is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a great expert on these matters, but at least here (compiling
for WebAssembly (
wasm32-unknown-unknown-wasm), I need this, otherwisesize_tis not available.