add mp_pack/unpack and MP_BUF error #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2019
minad
commented
Oct 8, 2019
minad
commented
Oct 8, 2019
minad
commented
Oct 8, 2019
minad
force-pushed
the
pack_unpack_buf
branch
5 times, most recently
from
907636f to
b770e8e
Compare
sjaeckel
reviewed
Oct 9, 2019
tests are library consumers, MP_MALLOC is an internal macro
Member
Author
|
@sjaeckel Things are indeed simpler if we do what you suggested. |
sjaeckel
approved these changes
Oct 10, 2019
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
@czurnieden you're fine with it like that too?
czurnieden
approved these changes
Oct 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #355 by @czurnieden. Buffer size measured by units as discussed in #355. @czurnieden I hope it is ok to base my PR on yours, since you might be busy with #343 ;) I also wanted to add something instead of only reviewing and nitpicking all the time.