Various fixes + split log_u32 #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czurnieden
approved these changes
Oct 19, 2019
Merged
sjaeckel
force-pushed
the
various-fixes
branch
from
7a71dc9 to
b6000bc
Compare
Member
Author
|
There are some bn_* files reintroduced here which should be renamed. |
Member
|
I've seen it just now. Will do the rename. |
sjaeckel
force-pushed
the
various-fixes
branch
from
b6000bc to
d608e7e
Compare
sjaeckel
force-pushed
the
various-fixes
branch
from
d608e7e to
94de1ce
Compare
sjaeckel
force-pushed
the
various-fixes
branch
from
94de1ce to
d8da85a
Compare
sjaeckel
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small oversights
Edit: I splitted the log function for more configurability and better readability