replace gen.pl by cat, rename mpi.c to mp_all.c #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minad
force-pushed
the
replace-gen-by-cat
branch
from
e3ddf94 to
0a5a8ac
Compare
sjaeckel
reviewed
Oct 28, 2019
Closed
this fixes #423
+ clean-up defines
sjaeckel
force-pushed
the
replace-gen-by-cat
branch
from
358c400 to
6020871
Compare
* less verbose output on console * allow changing name for logs * pre-heat caches before starting the timing
sjaeckel
force-pushed
the
replace-gen-by-cat
branch
from
6020871 to
02f4ee1
Compare
minad
commented
Oct 28, 2019
sjaeckel
force-pushed
the
replace-gen-by-cat
branch
from
681c27e to
9c40054
Compare
sjaeckel
force-pushed
the
replace-gen-by-cat
branch
from
9c40054 to
d800071
Compare
Member
|
This can be merged?! |
Member
|
btw. can anyone confirm that multiplication and exptmod are slower in the meant to be optimized/profiled build (the one called "after")? |
Member
|
btw. I just realized that the "before-after" graphics allow now an easy comparison of performance differences of branches $ git checkout develop
$ make -j9 timing CFLAGS='"-DMP_VERSION=\"before\""' && ./timing
$ git checkout fature-branch
$ make -j9 timing CFLAGS='"-DMP_VERSION=\"after\""' && ./timing
$ make -C logs/ cmp
$ xdg-open logs/before_after.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen.pl is an old artifact which can be easily replaced by standard unix cat. we already did some consolidation of perl scripts in #293.