Proposal: Remove long long support #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijtmans
approved these changes
Nov 22, 2019
Collaborator
nijtmans
left a comment
nijtmans
left a comment
There was a problem hiding this comment.
Well, I'm already preparing to made the switch to (u)int64_t for Tcl, I kind of saw this coming already ;-). So, just go ahead, as long as you don't backport this to support/1.x.
Member
Author
|
@nijtmans We would only deprecate the functions in 1.x. I also thought about making mp_get_ul macros pointing to either u32 or u64 as it has been before your PR #321. However one thing I realized and I am not too happy about is the selection of the function using the ternary operator, which again relies on dead code elimination. While we have that too for the MP_HAS macro, there it is purely a library internal thing. Here mp_get_ul is public api. |
* they are non standard * they are incompatible with older compilers * u64/i64 functions should be used instead * these functions should be deprecated again in 1.x
sjaeckel
force-pushed
the
long_long_fixes
branch
from
d14b358 to
cd1bf5e
Compare
sjaeckel
approved these changes
Nov 25, 2019
Member
|
This needs a sibling patch for 1.x #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to simply remove long long functions, since it is not c89 and u64/i64 can be used instead everywhere. I think that would work for most people. See also the table https://de.wikipedia.org/wiki/Datentypen_in_C#Datenmodell
These functions have been originally added in 2014 by @sjaeckel with the name mp_get_long_long etc.
Then I turned them in a macro in #285, which I think would still be an acceptable solution. Afterwards they were made explicit symbols by @nijtmans in #321. Now it seems @nijtmans needs some MSC_VER ifdef guards around these functions.
Would that work for you @nijtmans?