-
Notifications
You must be signed in to change notification settings - Fork 214
Follow-up of #489 #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up of #489 #490
Conversation
|
FYI, this are the results of building libtommath on linux gcc, linux clang, macos and windows msvc: conan-io/conan-center-index#2904 (comment) |
19fb37e to
2d0a8d6
Compare
czurnieden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell a lot about the Windows related changes, but the rest I like!
|
With the following changes, this pr allows building the tests linked to the dll. --- a/appveyor.yml
+++ b/appveyor.yml
@@ -19,3 +19,4 @@ build_script:
nmake -f makefile.msvc all
test_script:
- cmd: test.exe
+- cmd: test_dll.exe
--- a/makefile.msvc
+++ b/makefile.msvc
@@ -71,10 +71,15 @@ $(LIBMAIN_D) $(LIBMAIN_I): $(OBJECTS) tommath.def
#Build test suite
test.exe: $(LIBMAIN_S) demo/shared.obj demo/test.obj
- cl $(LTM_CFLAGS) $(TOBJECTS) $(LIBMAIN_S) $(LTM_LDFLAGS) demo/shared.c demo/test.c /Fe$@
+ link $(TOBJECTS) $(LTM_LDFLAGS) $? /out:$@
@echo NOTICE: start the tests by launching test.exe
-all: $(LIBMAIN_S) test.exe $(LIBMAIN_D)
+#Build test suite for dll
+test_dll.exe: $(LIBMAIN_I) demo/shared.obj demo/test.obj
+ link $(TOBJECTS) $(LTM_LDFLAGS) $? /out:$@
+ @echo NOTICE: start the tests by launching test_dll.exe
+
+all: $(LIBMAIN_S) test.exe $(LIBMAIN_D) test_dll.exe
tune: $(LIBMAIN_S)
$(MAKE) -C etc tune |
|
The test is failing in --- a/makefile.msvc
+++ b/makefile.msvc
@@ -11,7 +11,7 @@
#The following can be overridden from command line e.g. make -f makefile.msvc CC=gcc ARFLAGS=rcs
PREFIX = c:\devel
-CFLAGS = /Ox
+CFLAGS = /Ox /MD
LDFLAGS =
#Compilation flags |
b401b16 to
e798464
Compare
* move jenkins' prng out of the library into the demo's. * add CI test for shared library
czurnieden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu's Bionic Beaver is version 18.04, you might change the comment above the distribution settings in .travis.yml otherwise: looks good for me!
This is a follow-up of #489
It adds "automation" of the modifications to
tommath.defand a travis job to check for this.Additionally the proposed split-up of
mp_rand.cis done and the modifications tos_mp_rand_platform.care reverted.