Added check for __SIZEOF_INT128__ to avoid some problems with a 64-bit arch. and 32-bit userspace #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can give me a simple test I can test on 3.4 and 4.1..4.5, which I have around but which are too old to be used as system compilers. |
czurnieden
force-pushed
the
64bit_with_32bit_userspace
branch
from
bbc0cbb to
1073e98
Compare
Contributor
Author
|
As we are slowly removing the support for some the stone-old compilers we should be able to assume that the mentioned macro |
…t arch. and 32-bit userspace
sjaeckel
force-pushed
the
64bit_with_32bit_userspace
branch
from
1e62967 to
eb7fe2d
Compare
sjaeckel
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #509
The macro
__SIZEOF_INT128__is in GCC >= 4.6, CLANG >= 3.3, and ICC >= 16 (probably earlier but I don't have them), I do not know if anybody uses older compilers.