Fix: removed sign operation in s_mp_invmod_odd (issue #534) #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czurnieden
force-pushed
the
bugfix_invmod
branch
from
0776302 to
ffc1c2a
Compare
demo/test.c
Outdated
| if (e != MP_OKAY) { | ||
| if (results[i+10][j+10] != -1) { | ||
| printf("error = %s from ", mp_error_to_string(e)); | ||
| printf("error at i = %d, j =%d should be an error but gave %d\n",i,j, results[i+10][j+10]); |
Collaborator
There was a problem hiding this comment.
Shouldn't this print out the value of c instead of the expected results table?
Contributor
Author
There was a problem hiding this comment.
Yes, of course it should!
Thanks!
czurnieden
force-pushed
the
bugfix_invmod
branch
from
ffc1c2a to
ecf0160
Compare
Changed a check for <0 with mp_isneg() in s_mp_invmod Additional tests for mp_invmod() in demo/test.c
czurnieden
force-pushed
the
bugfix_invmod
branch
from
4896f32 to
908e098
Compare
friedrichsenm
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a check for <0 with mp_isneg() in s_mp_invmod
Additional tests for mp_invmod() in demo/test.c
This fixes #534