tcpkeepalive: distinguish OS versions and use proper time units #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has code conflicts with #4419, we might want to merge #4419 first. /cc @saghul @santigimeno |
saghul
reviewed
Jun 3, 2024
|
Ping @libuv/collaborators |
|
Kindly ping @santigimeno |
--------- Signed-off-by: Andy Pan <i@andypan.me>
panjf2000
force-pushed
the
tcp-keepalive-ms
branch
from
6e73228 to
b4a0fc0
Compare
|
@santigimeno got a minute for this? |
santigimeno
approved these changes
Jun 26, 2024
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DragonFly BSD changed the time unit for TCP keep-alive from milliseconds to seconds since v5.8 and Solaris 11.4 added
TCP_KEEPIDLE,TCP_KEEPINTVL, andTCP_KEEPCNTwith time units in second while Solaris <11.4 still useTCP_KEEPALIVE_THRESHOLDandTCP_KEEPALIVE_ABORT_THRESHOLDwith time units in millisecond.Currently, we don't differentiate among DragonFly BSD versions but set the keepalive options with seconds, which will result in unexpected behaviors on DragonFlyBSD <5.8. This PR intends to fix the wrong usage of time units of TCP keepalive options on DragonFly BSD <5.8 and consolidate the logic of time units conversion for TCP keepalive across platforms.
In addition, this PR introduces a new custom macro for determining Solaris 11.4. This macro is expected to help us implement some new features for
libuvusing some abilities that only exist on Solaris 11.4 and other mainstream platforms in the future, considering that Oracle developed and released Solaris 11.4 to replenish plenty of features on Solaris that have already been implemented on other UNIX-like OSs but missing from Solaris <11.4, also bring a good deal of new features.References