fix: Avoid extra memcpy in write callback

fix: Avoid extra cast in signal_connect

Author: L3tum

examples/streaming-bench.php

@@ -122,10 +122,10 @@
 
 $doBenchmark();
 
-echo "=== NOW NO CACHE ===" . PHP_EOL;
-
-Config::cacheSetMax(0);
-Config::cacheSetMaxFiles(0);
-Config::cacheSetMaxMem(0);
-
-$doBenchmark();
+//echo "=== NOW NO CACHE ===" . PHP_EOL;
+//
+//Config::cacheSetMax(0);
+//Config::cacheSetMaxFiles(0);
+//Config::cacheSetMaxMem(0);
+//
+//$doBenchmark();

src/GObject.php

@@ -171,7 +171,6 @@ public function signalConnect(string $name, Closure $callback): void
                 $bufferLength = (int) FFI::gobject()->g_value_get_int64(\FFI::addr($params[2]));
                 $buffer = \FFI::string($bufferPointer, $bufferLength);
                 $returnBufferLength = $callback($buffer);
-                \FFI::memcpy($bufferPointer, $buffer, $returnBufferLength);
                 FFI::gobject()->g_value_set_int64($returnValue, $returnBufferLength);
             };
             $marshalers['finish'] = static function (
@@ -211,10 +210,9 @@ public function signalConnect(string $name, Closure $callback): void
             throw new Exception("unsupported signal $name");
         }
 
-        $go = \FFI::cast(FFI::ctypes('GObject'), $this->pointer);
         $gc = FFI::gobject()->g_closure_new_simple(\FFI::sizeof(FFI::ctypes('GClosure')), null);
         $gc->marshal = $marshalers[$name];
-        FFI::gobject()->g_signal_connect_closure($go, $name, $gc, 0);
+        FFI::gobject()->g_signal_connect_closure($this->pointer, $name, $gc, 0);
     }
 }